Removed the implementation of CheckPlatformState.

chrome/browser/chromeos/attestation/platform_verification_flow.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform_verification_flow.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/chromeos/attestation/attestation_ca_client.h"
 #include "chrome/browser/chromeos/attestation/attestation_signed_data.pb.h"
 #include "chrome/browser/chromeos/attestation/platform_verification_dialog.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/prefs/scoped_user_pref_update.h"
 #include "chrome/common/pref_names.h"
 #include "chromeos/attestation/attestation_flow.h"
 #include "chromeos/cryptohome/async_method_caller.h"
 #include "chromeos/dbus/cryptohome_client.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
-#include "chromeos/system/statistics_provider.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "components/user_prefs/user_prefs.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 
 namespace {
 // A switch which allows consent to be given on the command line.
 // TODO(dkrahn): Remove this when UI has been implemented (crbug.com/270908).
 const char kAutoApproveSwitch[] =
@@ skipping 45 matching lines @@
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DefaultDelegate);
 };
 
 PlatformVerificationFlow::PlatformVerificationFlow()
     : attestation_flow_(NULL),
       async_caller_(cryptohome::AsyncMethodCaller::GetInstance()),
       cryptohome_client_(DBusThreadManager::Get()->GetCryptohomeClient()),
       user_manager_(UserManager::Get()),
-      statistics_provider_(system::StatisticsProvider::GetInstance()),
       delegate_(NULL),
       testing_prefs_(NULL),
       weak_factory_(this) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   scoped_ptr<ServerProxy> attestation_ca_client(new AttestationCAClient());
   default_attestation_flow_.reset(new AttestationFlow(
       async_caller_,
       cryptohome_client_,
       attestation_ca_client.Pass()));
   attestation_flow_ = default_attestation_flow_.get();
   default_delegate_.reset(new DefaultDelegate());
   delegate_ = default_delegate_.get();
 }
 
 PlatformVerificationFlow::PlatformVerificationFlow(
     AttestationFlow* attestation_flow,
     cryptohome::AsyncMethodCaller* async_caller,
     CryptohomeClient* cryptohome_client,
     UserManager* user_manager,
-    system::StatisticsProvider* statistics_provider,
     Delegate* delegate)
     : attestation_flow_(attestation_flow),
       async_caller_(async_caller),
       cryptohome_client_(cryptohome_client),
       user_manager_(user_manager),
-      statistics_provider_(statistics_provider),
       delegate_(delegate),
       testing_prefs_(NULL),
       weak_factory_(this) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 }
 
 PlatformVerificationFlow::~PlatformVerificationFlow() {
 }
 
 void PlatformVerificationFlow::ChallengePlatformKey(
@@ skipping 15 matching lines @@
                  service_id,
                  challenge,
                  callback),
       base::Bind(&ReportError, callback, INTERNAL_ERROR));
   cryptohome_client_->TpmAttestationIsEnrolled(dbus_callback);
 }
 
 void PlatformVerificationFlow::CheckPlatformState(
     const base::Callback<void(bool result)>& callback) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
-  std::string stat_value;
-  if (!statistics_provider_->GetMachineStatistic(system::kDevSwitchBootMode,
-                                                 &stat_value)) {
-    LOG(ERROR) << __func__ << ": Failed to get boot mode statistic.";
-    callback.Run(false);
-    return;
-  }
-  if (stat_value != "0") {
-    LOG(INFO) << __func__ << ": Statistic indicates developer mode.";
-    callback.Run(false);
-    return;
-  }
-  BoolDBusMethodCallback dbus_callback = base::Bind(
-      &DBusCallback,
-      callback,
-      base::Bind(callback, false));
-  cryptohome_client_->TpmAttestationIsPrepared(dbus_callback);
+  // The implementation of this method has been removed for two reasons:
+  // 1. It may be wrong and when it is a poor UX will follow.
+  // 2. It leaks platform state information which should stay internal.
+  // TODO(dkrahn): Remove the method once all callers have been cleaned up.
+  // crbug.com/307707
+  callback.Run(true);
 }
 
 void PlatformVerificationFlow::CheckConsent(content::WebContents* web_contents,
                                             const std::string& service_id,
                                             const std::string& challenge,
                                             const ChallengeCallback& callback,
                                             bool attestation_enrolled) {
   ConsentType consent_type = CONSENT_TYPE_NONE;
   if (!attestation_enrolled || IsFirstUse(web_contents)) {
     consent_type = CONSENT_TYPE_ATTESTATION;
@@ skipping 245 matching lines @@
     bool allow_domain) {
   PrefService* pref_service = GetPrefs(web_contents);
   CHECK(pref_service);
   DictionaryPrefUpdate updater(pref_service, prefs::kRAConsentDomains);
   const GURL& url = GetURL(web_contents);
   updater->SetBoolean(url.host(), allow_domain);
 }
 
 }  // namespace attestation
 }  // namespace chromeos