Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h

Issue 2732573003: Skip paint property update and visual rect update if no geometry change (Closed)
Patch Set: - Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
index 825ec46852384865814d277bf945a7dd10116a30..74a59ba803d5390b455da299a1473c0a0b533883 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
@@ -25,6 +25,9 @@ struct PaintPropertyTreeBuilderContext {
USING_FAST_MALLOC(PaintPropertyTreeBuilderContext);
public:
+ // Initializes all property tree nodes to the roots.
+ PaintPropertyTreeBuilderContext();
+
// State that propagates on the containing block chain (and so is adjusted
// when an absolute or fixed position object is encountered).
struct ContainingBlockContext {
@@ -90,8 +93,11 @@ struct PaintPropertyTreeBuilderContext {
// property tree changes (i.e., a node is added or removed).
bool forceSubtreeUpdate;
- // Initializes all property tree nodes to the roots.
- PaintPropertyTreeBuilderContext();
+#if DCHECK_IS_ON()
+ // When DCHECK_IS_ON() we create PaintPropertyTreeBuilderContext even if not
+ // needed. See FindPaintOffsetAndVisualRectNeedingUpdate.h.
+ bool isActuallyNeeded = true;
+#endif
};
// Creates paint property tree nodes for special things in the layout tree.

Powered by Google App Engine
This is Rietveld 408576698