Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2716483002: Add AstBuilder support for TypeArguments. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 10 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 4 chunks +2 lines, -16 lines 1 comment Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 10 months ago (2017-02-22 22:24:09 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-02-22 22:34:27 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as abcc4d4ad2f518b07b223816bdaacc7291097827 (presubmit successful).
3 years, 10 months ago (2017-02-22 23:50:31 UTC) #5
ahe
3 years, 10 months ago (2017-02-23 16:23:48 UTC) #6
Message was sent while issue was closed. 
lgtm

Just a random comment below.

https://codereview.chromium.org/2716483002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/parser_fasta_test.dart (right):

https://codereview.chromium.org/2716483002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/parser_fasta_test.dart:989: // TODO(paulberry): As
of commit 5de9108 this syntax is invalid.
FWIW, I believe that it is important that we're actually lenient in these cases.
That's the best strategy for error recovery.

Powered by Google App Engine
This is Rietveld 408576698