Add support for FieldFormalParameter.

Add support for FieldFormalParameter.

R=ahe@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/86c1ef03eee4de96a1d8fc1c8416cb8b4e75334b

[Paul Berry, 2017-02-22 20:41:09]

https://codereview.chromium.org/2716433002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2716433002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:484: period = token.next;
This seems problematic for error recovery.  If the next token isn't a '.', we
should set period to null.

[scheglov, 2017-02-23 06:43:50]

https://codereview.chromium.org/2716433002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2716433002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:484: period = token.next;
On 2017/02/22 20:41:09, Paul Berry wrote:
> This seems problematic for error recovery.  If the next token isn't a '.', we
> should set period to null.

This is the pattern that is used everywhere else in the parser.
See for example in parseDoWhileStatement().

Ideally of course we should recover just as we do in the Analyzer's
implementation, and create a synthetic token. But rewriting handling of invalid
cases and recovery seems out of scope of this CL. Might be a topic to discuss
tomorrow.

[ahe, 2017-02-23 16:27:11]

I'd prefer to not change the parser in this case.

https://codereview.chromium.org/2716433002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2716433002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:484: period = token.next;
On 2017/02/23 06:43:50, scheglov wrote:
> On 2017/02/22 20:41:09, Paul Berry wrote:
> > This seems problematic for error recovery.  If the next token isn't a '.',
we
> > should set period to null.
> 
> This is the pattern that is used everywhere else in the parser.
> See for example in parseDoWhileStatement().
> 
> Ideally of course we should recover just as we do in the Analyzer's
> implementation, and create a synthetic token. But rewriting handling of
invalid
> cases and recovery seems out of scope of this CL. Might be a topic to discuss
> tomorrow.

I agree that it is a problem for error recovery.

https://codereview.chromium.org/2716433002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:515:
listener.endFormalParameter(thisKeyword, period);
This isn't necessary. The period can be found without guessing by looking at
thisKeyword.

[scheglov, 2017-02-23 17:34:44]

PTAL

I decided to rollback parser changes until we get a decision for recovery.

[ahe, 2017-02-23 17:39:18]

lgtm

https://codereview.chromium.org/2716433002/diff/20001/pkg/front_end/front_end...
File pkg/front_end/front_end.iml (right):

https://codereview.chromium.org/2716433002/diff/20001/pkg/front_end/front_end...
pkg/front_end/front_end.iml:10: <orderEntry type="library" name="Dart Packages"
level="project" />
Is this change intentional?

[scheglov, 2017-02-23 17:42:49]

Description was changed from

==========
Add support for FieldFormalParameter.

R=ahe@google.com, paulberry@google.com
BUG=
==========

to

==========
Add support for FieldFormalParameter.

R=ahe@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/86c1ef03eee4de96a1d8fc1c8416cb8b4e75334b
==========

[scheglov, 2017-02-23 17:42:50]

Committed patchset #2 (id:20001) manually as
86c1ef03eee4de96a1d8fc1c8416cb8b4e75334b (presubmit successful).