Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2715823004: Add FingerprintUnlock KeyedService for each profile (Closed)

Created:
3 years, 10 months ago by xiaoyinh(OOO Sep 11-29)
Modified:
3 years, 9 months ago
Reviewers:
rkc, stevenjb, jdufault
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add FingerprintUnlock KeyedService that will keep track of the fingerprint unlock attempt, fingerprint unlock availablity etc. for each profile. BUG=695952 Review-Url: https://codereview.chromium.org/2715823004 Cr-Commit-Position: refs/heads/master@{#454026} Committed: https://chromium.googlesource.com/chromium/src/+/37eb295b58bab1ac11d55fbecfc4cf1a8f75272f

Patch Set 1 #

Total comments: 15

Patch Set 2 : Incorporate comments #

Total comments: 2

Patch Set 3 : Move strong auth logic and tests to QuickUnlockStorage. #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+726 lines, -375 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc View 1 2 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc View 1 2 3 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 2 5 chunks +20 lines, -17 lines 0 comments Download
A chrome/browser/chromeos/login/quick_unlock/fingerprint_storage.h View 1 2 3 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/quick_unlock/fingerprint_storage.cc View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/quick_unlock/fingerprint_storage_unittest.cc View 1 2 1 chunk +107 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/quick_unlock/pin_storage.h View 1 2 3 5 chunks +8 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/login/quick_unlock/pin_storage.cc View 1 2 3 chunks +1 line, -41 lines 0 comments Download
D chrome/browser/chromeos/login/quick_unlock/pin_storage_factory.h View 1 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/chromeos/login/quick_unlock/pin_storage_factory.cc View 1 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/browser/chromeos/login/quick_unlock/pin_storage_unittest.cc View 1 2 6 chunks +24 lines, -121 lines 0 comments Download
A chrome/browser/chromeos/login/quick_unlock/quick_unlock_factory.h View 1 1 chunk +58 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/login/quick_unlock/quick_unlock_factory.cc View 1 4 chunks +17 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
A chrome/browser/chromeos/login/quick_unlock/quick_unlock_storage.h View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/quick_unlock/quick_unlock_storage.cc View 1 2 1 chunk +74 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/quick_unlock/quick_unlock_storage_unittest.cc View 1 2 1 chunk +152 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.cc View 3 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 1 2 4 chunks +22 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 3 4 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 38 (26 generated)
xiaoyinh(OOO Sep 11-29)
Please take a look. Thanks!
3 years, 10 months ago (2017-02-24 22:59:25 UTC) #7
jdufault
On 2017/02/24 22:59:25, xiaoyinh wrote: > Please take a look. Thanks! Some of this duplication ...
3 years, 10 months ago (2017-02-24 23:37:01 UTC) #8
jdufault
https://codereview.chromium.org/2715823004/diff/1/chrome/browser/chromeos/login/lock/screen_locker.cc File chrome/browser/chromeos/login/lock/screen_locker.cc (right): https://codereview.chromium.org/2715823004/diff/1/chrome/browser/chromeos/login/lock/screen_locker.cc#newcode261 chrome/browser/chromeos/login/lock/screen_locker.cc:261: quick_unlock::FingerprintUnlockFactory::GetForAccountId( GetForUser? https://codereview.chromium.org/2715823004/diff/1/chrome/browser/chromeos/login/quick_unlock/fingerprint_unlock.cc File chrome/browser/chromeos/login/quick_unlock/fingerprint_unlock.cc (right): https://codereview.chromium.org/2715823004/diff/1/chrome/browser/chromeos/login/quick_unlock/fingerprint_unlock.cc#newcode28 chrome/browser/chromeos/login/quick_unlock/fingerprint_unlock.cc:28: // ...
3 years, 10 months ago (2017-02-24 23:37:10 UTC) #9
stevenjb
https://codereview.chromium.org/2715823004/diff/1/chrome/browser/chromeos/login/quick_unlock/fingerprint_unlock.h File chrome/browser/chromeos/login/quick_unlock/fingerprint_unlock.h (right): https://codereview.chromium.org/2715823004/diff/1/chrome/browser/chromeos/login/quick_unlock/fingerprint_unlock.h#newcode46 chrome/browser/chromeos/login/quick_unlock/fingerprint_unlock.h:46: int unlock_attempt_count() const { return unlock_attempt_count_; } nit: comment ...
3 years, 9 months ago (2017-02-27 17:25:34 UTC) #10
xiaoyinh(OOO Sep 11-29)
https://codereview.chromium.org/2715823004/diff/1/chrome/browser/chromeos/login/lock/screen_locker.cc File chrome/browser/chromeos/login/lock/screen_locker.cc (right): https://codereview.chromium.org/2715823004/diff/1/chrome/browser/chromeos/login/lock/screen_locker.cc#newcode261 chrome/browser/chromeos/login/lock/screen_locker.cc:261: quick_unlock::FingerprintUnlockFactory::GetForAccountId( On 2017/02/24 23:37:10, jdufault wrote: > GetForUser? Changed. ...
3 years, 9 months ago (2017-02-27 21:36:43 UTC) #13
jdufault
https://codereview.chromium.org/2715823004/diff/1/chrome/browser/chromeos/login/quick_unlock/fingerprint_unlock.cc File chrome/browser/chromeos/login/quick_unlock/fingerprint_unlock.cc (right): https://codereview.chromium.org/2715823004/diff/1/chrome/browser/chromeos/login/quick_unlock/fingerprint_unlock.cc#newcode28 chrome/browser/chromeos/login/quick_unlock/fingerprint_unlock.cc:28: // Assume the policy for fingerprint is same as ...
3 years, 9 months ago (2017-02-27 21:38:38 UTC) #14
stevenjb
owner lgtm
3 years, 9 months ago (2017-02-27 21:41:16 UTC) #15
jdufault
https://codereview.chromium.org/2715823004/diff/20001/chrome/browser/chromeos/login/quick_unlock/fingerprint_storage_unittest.cc File chrome/browser/chromeos/login/quick_unlock/fingerprint_storage_unittest.cc (right): https://codereview.chromium.org/2715823004/diff/20001/chrome/browser/chromeos/login/quick_unlock/fingerprint_storage_unittest.cc#newcode117 chrome/browser/chromeos/login/quick_unlock/fingerprint_storage_unittest.cc:117: TEST_F(FingerprintStorageUnitTest, You should be able to remove these strong ...
3 years, 9 months ago (2017-02-27 21:41:51 UTC) #16
xiaoyinh(OOO Sep 11-29)
https://codereview.chromium.org/2715823004/diff/20001/chrome/browser/chromeos/login/quick_unlock/fingerprint_storage_unittest.cc File chrome/browser/chromeos/login/quick_unlock/fingerprint_storage_unittest.cc (right): https://codereview.chromium.org/2715823004/diff/20001/chrome/browser/chromeos/login/quick_unlock/fingerprint_storage_unittest.cc#newcode117 chrome/browser/chromeos/login/quick_unlock/fingerprint_storage_unittest.cc:117: TEST_F(FingerprintStorageUnitTest, On 2017/02/27 21:41:50, jdufault wrote: > You should ...
3 years, 9 months ago (2017-02-28 01:20:49 UTC) #23
jdufault
lgtm, thanks!
3 years, 9 months ago (2017-02-28 01:35:39 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715823004/80001
3 years, 9 months ago (2017-03-01 21:02:05 UTC) #35
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 21:07:40 UTC) #38
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/37eb295b58bab1ac11d55fbecfc4...

Powered by Google App Engine
This is Rietveld 408576698