Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: content/browser/media/session/media_session_service_impl.h

Issue 2715723002: Fix a crash in MediaSessionServiceImpl due to life time issue (Closed)
Patch Set: addressed nits Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/session/media_session_service_impl.h
diff --git a/content/browser/media/session/media_session_service_impl.h b/content/browser/media/session/media_session_service_impl.h
index 5f1348630b80f6b78a1394fcdc92777331d2944f..03113849082c18559df69e4003463366116d60ec 100644
--- a/content/browser/media/session/media_session_service_impl.h
+++ b/content/browser/media/session/media_session_service_impl.h
@@ -26,7 +26,7 @@ class CONTENT_EXPORT MediaSessionServiceImpl
static void Create(RenderFrameHost* render_frame_host,
blink::mojom::MediaSessionServiceRequest request);
const blink::mojom::MediaSessionClientPtr& GetClient() { return client_; }
- RenderFrameHost* GetRenderFrameHost() { return render_frame_host_; }
+ RenderFrameHost* GetRenderFrameHost();
blink::mojom::MediaSessionPlaybackState playback_state() const {
return playback_state_;
@@ -53,7 +53,8 @@ class CONTENT_EXPORT MediaSessionServiceImpl
void Bind(blink::mojom::MediaSessionServiceRequest request);
- RenderFrameHost* render_frame_host_;
+ const int render_frame_process_id_;
+ const int render_frame_routing_id_;
// RAII binding of |this| to an MediaSessionService interface request.
// The binding is removed when binding_ is cleared or goes out of scope.
« no previous file with comments | « content/browser/media/session/media_session_impl.cc ('k') | content/browser/media/session/media_session_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698