Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: content/browser/media/session/media_session_service_impl.h

Issue 2715723002: Fix a crash in MediaSessionServiceImpl due to life time issue (Closed)
Patch Set: addressed nits Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_MEDIA_SESSION_MEDIA_SESSION_SERVICE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_MEDIA_SESSION_MEDIA_SESSION_SERVICE_IMPL_H_
6 #define CONTENT_BROWSER_MEDIA_SESSION_MEDIA_SESSION_SERVICE_IMPL_H_ 6 #define CONTENT_BROWSER_MEDIA_SESSION_MEDIA_SESSION_SERVICE_IMPL_H_
7 7
8 #include "base/optional.h" 8 #include "base/optional.h"
9 #include "content/public/common/media_metadata.h" 9 #include "content/public/common/media_metadata.h"
10 #include "mojo/public/cpp/bindings/binding.h" 10 #include "mojo/public/cpp/bindings/binding.h"
11 #include "third_party/WebKit/public/platform/modules/mediasession/media_session. mojom.h" 11 #include "third_party/WebKit/public/platform/modules/mediasession/media_session. mojom.h"
12 12
13 namespace content { 13 namespace content {
14 14
15 class RenderFrameHost; 15 class RenderFrameHost;
16 class MediaSessionImpl; 16 class MediaSessionImpl;
17 17
18 // There is one MediaSessionService per frame. The class is owned by 18 // There is one MediaSessionService per frame. The class is owned by
19 // RenderFrameHost and should register/unregister itself to/from 19 // RenderFrameHost and should register/unregister itself to/from
20 // MediaSessionImpl when RenderFrameHost is created/destroyed. 20 // MediaSessionImpl when RenderFrameHost is created/destroyed.
21 class CONTENT_EXPORT MediaSessionServiceImpl 21 class CONTENT_EXPORT MediaSessionServiceImpl
22 : public blink::mojom::MediaSessionService { 22 : public blink::mojom::MediaSessionService {
23 public: 23 public:
24 ~MediaSessionServiceImpl() override; 24 ~MediaSessionServiceImpl() override;
25 25
26 static void Create(RenderFrameHost* render_frame_host, 26 static void Create(RenderFrameHost* render_frame_host,
27 blink::mojom::MediaSessionServiceRequest request); 27 blink::mojom::MediaSessionServiceRequest request);
28 const blink::mojom::MediaSessionClientPtr& GetClient() { return client_; } 28 const blink::mojom::MediaSessionClientPtr& GetClient() { return client_; }
29 RenderFrameHost* GetRenderFrameHost() { return render_frame_host_; } 29 RenderFrameHost* GetRenderFrameHost();
30 30
31 blink::mojom::MediaSessionPlaybackState playback_state() const { 31 blink::mojom::MediaSessionPlaybackState playback_state() const {
32 return playback_state_; 32 return playback_state_;
33 } 33 }
34 const base::Optional<MediaMetadata>& metadata() const { return metadata_; } 34 const base::Optional<MediaMetadata>& metadata() const { return metadata_; }
35 const std::set<blink::mojom::MediaSessionAction>& actions() const { 35 const std::set<blink::mojom::MediaSessionAction>& actions() const {
36 return actions_; 36 return actions_;
37 } 37 }
38 38
39 // blink::mojom::MediaSessionService implementation. 39 // blink::mojom::MediaSessionService implementation.
40 void SetClient(blink::mojom::MediaSessionClientPtr client) override; 40 void SetClient(blink::mojom::MediaSessionClientPtr client) override;
41 41
42 void SetPlaybackState(blink::mojom::MediaSessionPlaybackState state) override; 42 void SetPlaybackState(blink::mojom::MediaSessionPlaybackState state) override;
43 void SetMetadata(const base::Optional<MediaMetadata>& metadata) override; 43 void SetMetadata(const base::Optional<MediaMetadata>& metadata) override;
44 44
45 void EnableAction(blink::mojom::MediaSessionAction action) override; 45 void EnableAction(blink::mojom::MediaSessionAction action) override;
46 void DisableAction(blink::mojom::MediaSessionAction action) override; 46 void DisableAction(blink::mojom::MediaSessionAction action) override;
47 47
48 protected: 48 protected:
49 explicit MediaSessionServiceImpl(RenderFrameHost* render_frame_host); 49 explicit MediaSessionServiceImpl(RenderFrameHost* render_frame_host);
50 50
51 private: 51 private:
52 MediaSessionImpl* GetMediaSession(); 52 MediaSessionImpl* GetMediaSession();
53 53
54 void Bind(blink::mojom::MediaSessionServiceRequest request); 54 void Bind(blink::mojom::MediaSessionServiceRequest request);
55 55
56 RenderFrameHost* render_frame_host_; 56 const int render_frame_process_id_;
57 const int render_frame_routing_id_;
57 58
58 // RAII binding of |this| to an MediaSessionService interface request. 59 // RAII binding of |this| to an MediaSessionService interface request.
59 // The binding is removed when binding_ is cleared or goes out of scope. 60 // The binding is removed when binding_ is cleared or goes out of scope.
60 std::unique_ptr<mojo::Binding<blink::mojom::MediaSessionService>> binding_; 61 std::unique_ptr<mojo::Binding<blink::mojom::MediaSessionService>> binding_;
61 blink::mojom::MediaSessionClientPtr client_; 62 blink::mojom::MediaSessionClientPtr client_;
62 blink::mojom::MediaSessionPlaybackState playback_state_; 63 blink::mojom::MediaSessionPlaybackState playback_state_;
63 base::Optional<MediaMetadata> metadata_; 64 base::Optional<MediaMetadata> metadata_;
64 std::set<blink::mojom::MediaSessionAction> actions_; 65 std::set<blink::mojom::MediaSessionAction> actions_;
65 66
66 DISALLOW_COPY_AND_ASSIGN(MediaSessionServiceImpl); 67 DISALLOW_COPY_AND_ASSIGN(MediaSessionServiceImpl);
67 }; 68 };
68 69
69 } // namespace content 70 } // namespace content
70 71
71 #endif // CONTENT_BROWSER_MEDIA_SESSION_MEDIA_SESSION_SERVICE_IMPL_H_ 72 #endif // CONTENT_BROWSER_MEDIA_SESSION_MEDIA_SESSION_SERVICE_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/media/session/media_session_impl.cc ('k') | content/browser/media/session/media_session_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698