Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 2713853002: remove x86_abi_support from source list (Closed)

Created:
3 years, 10 months ago by kthelgason_chromium
Modified:
3 years, 10 months ago
Reviewers:
Johann
CC:
chromium-reviews, wwcv, jzern, fgalligan1, Tom Finegan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove x86_abi_support from source list BUG=chromium:695404 Review-Url: https://codereview.chromium.org/2713853002 Cr-Commit-Position: refs/heads/master@{#452509} Committed: https://chromium.googlesource.com/chromium/src/+/ecd5d94adb8e604304ed27b7c1ffc2c8225cfa28

Patch Set 1 #

Patch Set 2 : filter out include files when generating gni #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/libvpx/generate_gni.sh View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/libvpx/libvpx_srcs.gni View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
kthelgason_chromium
Johann, please take a look.
3 years, 10 months ago (2017-02-23 12:11:37 UTC) #4
Johann
lgtm
3 years, 10 months ago (2017-02-23 13:45:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713853002/20001
3 years, 10 months ago (2017-02-23 16:02:49 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 16:09:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ecd5d94adb8e604304ed27b7c1ff...

Powered by Google App Engine
This is Rietveld 408576698