[Webview, Child Accounts] Always Google Play Services to show the reauthentication page.

[Webview, Child Accounts] Always allow Google Play Services to show the reauthentication page.

The reauthentication page is necessary to fix account issues e.g. after
a password change. The whitelisting is only for accounts.google.com
and only if the calling package is the Google Play Services UI.

BUG=695048
Review-Url: https://codereview.chromium.org/2713513004
Cr-Commit-Position: refs/heads/master@{#452528}
Committed: https://chromium.googlesource.com/chromium/src/+/47c6658e306effae6981843a7352972048e7c7ef

[Bernhard Bauer, 2017-02-22 15:13:22]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 15:13:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2017-02-22 16:24:18]

Description was changed from

==========
Always allow WebView in Google Play Services to show the reauthentication page
for child accounts.

The reauthentication page is necessary to fix account issues e.g. after
a password change. The whitelisting is only for accounts.google.com
and only if the calling package is the Google Play Services UI.

BUG=695048
==========

to

==========
[Webview, Child Accounts] Always Google Play Services to show the
reauthentication page.

The reauthentication page is necessary to fix account issues e.g. after
a password change. The whitelisting is only for accounts.google.com
and only if the calling package is the Google Play Services UI.

BUG=695048
==========

[commit-bot: I haz the power, 2017-02-22 16:41:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 16:41:12]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Bernhard Bauer, 2017-02-22 18:10:58]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 18:11:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 18:29:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 18:29:10]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Bernhard Bauer, 2017-02-22 21:31:01]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 21:31:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 22:09:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 22:09:12]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Bernhard Bauer, 2017-02-22 22:23:29]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 22:24:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 23:53:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 23:53:21]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Bernhard Bauer, 2017-02-23 11:02:03]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 11:02:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 11:56:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 11:56:18]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-02-23 11:56:43]

Description was changed from

==========
[Webview, Child Accounts] Always Google Play Services to show the
reauthentication page.

The reauthentication page is necessary to fix account issues e.g. after
a password change. The whitelisting is only for accounts.google.com
and only if the calling package is the Google Play Services UI.

BUG=695048
==========

to

==========
[Webview, Child Accounts] Always allow Google Play Services to show the
reauthentication page.

The reauthentication page is necessary to fix account issues e.g. after
a password change. The whitelisting is only for accounts.google.com
and only if the calling package is the Google Play Services UI.

BUG=695048
==========

[Bernhard Bauer, 2017-02-23 11:57:19]

bauerb@chromium.org changed reviewers:
+ dgn@chromium.org

[Bernhard Bauer, 2017-02-23 11:57:20]

Nicolas, could you take a look in Anthony's absence?

[dgn, 2017-02-23 12:19:50]

lgtm

https://codereview.chromium.org/2713513004/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProvider.java
(right):

https://codereview.chromium.org/2713513004/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProvider.java:212:
return callingPackage != null &&
callingPackage.equals(GOOGLE_PLAY_SERVICES_UI_PACKAGE)
nit: TextUtils.equals() to avoid having to check for null?

https://codereview.chromium.org/2713513004/diff/80001/chrome/android/junit/sr...
File
chrome/android/junit/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderUnitTest.java
(right):

https://codereview.chromium.org/2713513004/diff/80001/chrome/android/junit/sr...
chrome/android/junit/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderUnitTest.java:288:
WebRestrictionsResult wrongCallingPackage =
mSupervisedUserContentProvider.shouldProceed(
Test for the null package too?

https://codereview.chromium.org/2713513004/diff/80001/components/web_restrict...
File
components/web_restrictions/browser/junit/src/org/chromium/components/webrestrictions/browser/WebRestrictionsContentProviderTest.java
(right):

https://codereview.chromium.org/2713513004/diff/80001/components/web_restrict...
components/web_restrictions/browser/junit/src/org/chromium/components/webrestrictions/browser/WebRestrictionsContentProviderTest.java:102:
verify(mContentProvider).shouldProceed(ArgumentMatchers.<String>isNull(),
eq("dummy"));
doesn't `.shouldProceed(null, "dummy")` work here?

[Bernhard Bauer, 2017-02-23 16:36:22]

Thanks!

https://codereview.chromium.org/2713513004/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProvider.java
(right):

https://codereview.chromium.org/2713513004/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProvider.java:212:
return callingPackage != null &&
callingPackage.equals(GOOGLE_PLAY_SERVICES_UI_PACKAGE)
On 2017/02/23 12:19:49, dgn wrote:
> nit: TextUtils.equals() to avoid having to check for null?

Good idea! Done.

https://codereview.chromium.org/2713513004/diff/80001/chrome/android/junit/sr...
File
chrome/android/junit/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderUnitTest.java
(right):

https://codereview.chromium.org/2713513004/diff/80001/chrome/android/junit/sr...
chrome/android/junit/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderUnitTest.java:288:
WebRestrictionsResult wrongCallingPackage =
mSupervisedUserContentProvider.shouldProceed(
On 2017/02/23 12:19:49, dgn wrote:
> Test for the null package too?

Done.

https://codereview.chromium.org/2713513004/diff/80001/components/web_restrict...
File
components/web_restrictions/browser/junit/src/org/chromium/components/webrestrictions/browser/WebRestrictionsContentProviderTest.java
(right):

https://codereview.chromium.org/2713513004/diff/80001/components/web_restrict...
components/web_restrictions/browser/junit/src/org/chromium/components/webrestrictions/browser/WebRestrictionsContentProviderTest.java:102:
verify(mContentProvider).shouldProceed(ArgumentMatchers.<String>isNull(),
eq("dummy"));
On 2017/02/23 12:19:49, dgn wrote:
> doesn't `.shouldProceed(null, "dummy")` work here?

Yes, if I don't use eq() for the second argument. Done.

[Bernhard Bauer, 2017-02-23 16:36:25]

The CQ bit was checked by bauerb@chromium.org

[Bernhard Bauer, 2017-02-23 16:36:26]

The patchset sent to the CQ was uploaded after l-g-t-m from dgn@chromium.org
Link to the patchset: https://codereview.chromium.org/2713513004/#ps100001
(title: "review")

[commit-bot: I haz the power, 2017-02-23 16:37:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 17:14:09]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487867785863630,
"parent_rev": "f302b212b55f72414133fb3d7de74a809d85d933", "commit_rev":
"47c6658e306effae6981843a7352972048e7c7ef"}

[commit-bot: I haz the power, 2017-02-23 17:14:44]

Description was changed from

==========
[Webview, Child Accounts] Always allow Google Play Services to show the
reauthentication page.

The reauthentication page is necessary to fix account issues e.g. after
a password change. The whitelisting is only for accounts.google.com
and only if the calling package is the Google Play Services UI.

BUG=695048
==========

to

==========
[Webview, Child Accounts] Always allow Google Play Services to show the
reauthentication page.

The reauthentication page is necessary to fix account issues e.g. after
a password change. The whitelisting is only for accounts.google.com
and only if the calling package is the Google Play Services UI.

BUG=695048

Review-Url: https://codereview.chromium.org/2713513004
Cr-Commit-Position: refs/heads/master@{#452528}
Committed:
https://chromium.googlesource.com/chromium/src/+/47c6658e306effae6981843a7352...
==========

[commit-bot: I haz the power, 2017-02-23 17:14:45]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/47c6658e306effae6981843a7352...