Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: ios/chrome/browser/tabs/tab_model.h

Issue 2712743008: Remove -insertTabWithWebState:atIndex: from TabModel. (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/chrome/browser/tabs/tab_model.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_model.h
diff --git a/ios/chrome/browser/tabs/tab_model.h b/ios/chrome/browser/tabs/tab_model.h
index aab016e1489ab47eddbe62ee633e4355d04773c9..30a2499bd4552eafddf18ff850b81f3b91a763af 100644
--- a/ios/chrome/browser/tabs/tab_model.h
+++ b/ios/chrome/browser/tabs/tab_model.h
@@ -10,6 +10,7 @@
#include <memory>
+#import "ios/web/public/navigation_item_list.h"
#import "ios/web/public/navigation_manager.h"
#include "ui/base/page_transition_types.h"
@@ -199,11 +200,14 @@ NSUInteger const kTabPositionAutomatically = NSNotFound;
atIndex:(NSUInteger)index
inBackground:(BOOL)inBackground;
-// Inserts a new tab at the given |index| with the session history specified by
-// |webState|. Does not go through the order controller as this is generally
-// used only for restoring a previous session and the index is fixed.
-- (Tab*)insertTabWithWebState:(std::unique_ptr<web::WebState>)webState
- atIndex:(NSUInteger)index;
+// Inserts a new Tab at the given |index| restoring the session history from
+// the provided |navigationItems| and updates the current tab if |inBackground|
+// is NO.
+- (Tab*)insertTabWithNavigationItems:
+ (web::ScopedNavigationItemList)navigationItems
+ selectedNavigationIndex:(int)selectedNavigationIndex
+ atIndex:(NSUInteger)index
+ inBackground:(BOOL)inBackground;
// Inserts |tab| at the given |index|. Broadcasts the proper notifications about
// the change. The receiver should be set as the parentTabModel for |tab|; this
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/chrome/browser/tabs/tab_model.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698