[Payment Request] Payment request summary view pending state

[Payment Request] Payment request summary view pending state
screenshot: http://imgur.com/a/t05eG

BUG=602666
Review-Url: https://codereview.chromium.org/2710683012
Cr-Commit-Position: refs/heads/master@{#452970}
Committed: https://chromium.googlesource.com/chromium/src/+/31cc5805fa24ca2c9161ec1b93cc7fe3662d9739

[Moe, 2017-02-23 14:48:16]

mahmadi@chromium.org changed reviewers:
+ lpromero@chromium.org

[Moe, 2017-02-23 14:48:16]

Hi louis, Please take a look at this CL.

[Moe, 2017-02-23 14:52:57]

Description was changed from

==========
[Payment Request] Payment request summary view pending state
==========

to

==========
[Payment Request] Payment request summary view pending state
screenshot: http://imgur.com/a/t05eG

BUG=602666
==========

[lpromero, 2017-02-23 15:27:52]

lgtm

https://codereview.chromium.org/2710683012/diff/1/components/payments_strings...
File components/payments_strings.grdp (right):

https://codereview.chromium.org/2710683012/diff/1/components/payments_strings...
components/payments_strings.grdp:73: <message
name="IDS_PAYMENTS_PROCESSING_MESSAGE" desc="The text that informs the user that
payment is being processed." formatter_data="android_java">
What doe the formatter_data do?

https://codereview.chromium.org/2710683012/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_request_view_controller.h (right):

https://codereview.chromium.org/2710683012/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request_view_controller.h:61:
@property(nonatomic, assign) BOOL isPending;
Nit:
@property(nonatomic, assign, getter="isPending") BOOL pending;

[Moe, 2017-02-23 16:22:27]

mahmadi@chromium.org changed reviewers:
+ rouslan@chromium.org

[Moe, 2017-02-23 16:22:28]

Thanks Louis,
TBR=rouslan@ for components/payments_strings.grdp

https://codereview.chromium.org/2710683012/diff/1/components/payments_strings...
File components/payments_strings.grdp (right):

https://codereview.chromium.org/2710683012/diff/1/components/payments_strings...
components/payments_strings.grdp:73: <message
name="IDS_PAYMENTS_PROCESSING_MESSAGE" desc="The text that informs the user that
payment is being processed." formatter_data="android_java">
On 2017/02/23 15:27:52, lpromero wrote:
> What doe the formatter_data do?

Creates a Java version of the string to be used through @string/[resource_name]
or R.string.[resource_name] 
These strings are shared between platforms.

https://codereview.chromium.org/2710683012/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_request_view_controller.h (right):

https://codereview.chromium.org/2710683012/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request_view_controller.h:61:
@property(nonatomic, assign) BOOL isPending;
On 2017/02/23 15:27:52, lpromero wrote:
> Nit:
> @property(nonatomic, assign, getter="isPending") BOOL pending;

Done.

[please use gerrit instead, 2017-02-23 16:24:51]

strings LGTM % comment

https://codereview.chromium.org/2710683012/diff/20001/components/payments_str...
File components/payments_strings.grdp (right):

https://codereview.chromium.org/2710683012/diff/20001/components/payments_str...
components/payments_strings.grdp:73: <message
name="IDS_PAYMENTS_PROCESSING_MESSAGE" desc="The text that informs the user that
payment is being processed." formatter_data="android_java">
Please ask UX to double-check the use of "Loading" and "Processing" strings
across iOS and Android. Currently Android uses only "Loading" string.

[Moe, 2017-02-23 16:34:08]

https://codereview.chromium.org/2710683012/diff/20001/components/payments_str...
File components/payments_strings.grdp (right):

https://codereview.chromium.org/2710683012/diff/20001/components/payments_str...
components/payments_strings.grdp:73: <message
name="IDS_PAYMENTS_PROCESSING_MESSAGE" desc="The text that informs the user that
payment is being processed." formatter_data="android_java">
On 2017/02/23 16:24:51, rouslan wrote:
> Please ask UX to double-check the use of "Loading" and "Processing" strings
> across iOS and Android. Currently Android uses only "Loading" string.

"loading" should be shown in the initial loading of the PR and "processing" when
the payment is being processed. Mocks seem to suggest that. There's also
"checking" for when address/shipping option changes.

[Moe, 2017-02-24 21:17:54]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 21:18:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 21:34:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 21:34:08]

Dry run: This issue passed the CQ dry run.

[Moe, 2017-02-24 22:40:37]

On 2017/02/23 16:34:08, moe wrote:
>
https://codereview.chromium.org/2710683012/diff/20001/components/payments_str...
> File components/payments_strings.grdp (right):
> 
>
https://codereview.chromium.org/2710683012/diff/20001/components/payments_str...
> components/payments_strings.grdp:73: <message
> name="IDS_PAYMENTS_PROCESSING_MESSAGE" desc="The text that informs the user
that
> payment is being processed." formatter_data="android_java">
> On 2017/02/23 16:24:51, rouslan wrote:
> > Please ask UX to double-check the use of "Loading" and "Processing" strings
> > across iOS and Android. Currently Android uses only "Loading" string.
> 
> "loading" should be shown in the initial loading of the PR and "processing"
when
> the payment is being processed. Mocks seem to suggest that. There's also
> "checking" for when address/shipping option changes.

Thank you.

[Moe, 2017-02-24 22:40:44]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-02-24 22:40:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org, rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2710683012/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-24 22:41:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 22:50:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487976044198360,
"parent_rev": "2b7d72f872ab3c2e590ac008c7dd8ac426982d48", "commit_rev":
"31cc5805fa24ca2c9161ec1b93cc7fe3662d9739"}

[commit-bot: I haz the power, 2017-02-24 22:50:56]

Description was changed from

==========
[Payment Request] Payment request summary view pending state
screenshot: http://imgur.com/a/t05eG

BUG=602666
==========

to

==========
[Payment Request] Payment request summary view pending state
screenshot: http://imgur.com/a/t05eG

BUG=602666

Review-Url: https://codereview.chromium.org/2710683012
Cr-Commit-Position: refs/heads/master@{#452970}
Committed:
https://chromium.googlesource.com/chromium/src/+/31cc5805fa24ca2c9161ec1b93cc...
==========

[commit-bot: I haz the power, 2017-02-24 22:51:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/31cc5805fa24ca2c9161ec1b93cc...