Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2708733003: WebStateListObserver methods have default implementation. (Closed)

Created:
3 years, 10 months ago by sdefresne
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebStateListObserver methods have default implementation. As most of the observer are only interested in a sub-set of the events and to mirror the Objective-C API (WebStateListObserving) that marks all methods as optional, add empty implementation to WebStateList methods. BUG=687207 Review-Url: https://codereview.chromium.org/2708733003 Cr-Commit-Position: refs/heads/master@{#452516} Committed: https://chromium.googlesource.com/chromium/src/+/073e0546fc624d92d47dcf4778fdce5a2391f835

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -31 lines) Patch
M ios/chrome/browser/tabs/tab_parenting_observer.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ios/chrome/browser/tabs/tab_parenting_observer.mm View 1 chunk +0 lines, -9 lines 0 comments Download
M ios/shared/chrome/browser/tabs/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/shared/chrome/browser/tabs/web_state_list_metrics_observer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/shared/chrome/browser/tabs/web_state_list_metrics_observer.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/shared/chrome/browser/tabs/web_state_list_observer.h View 1 chunk +6 lines, -6 lines 0 comments Download
A ios/shared/chrome/browser/tabs/web_state_list_observer.mm View 1 chunk +27 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
sdefresne
To whoever would be the faster to review.
3 years, 10 months ago (2017-02-21 15:49:59 UTC) #2
marq (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-21 16:19:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708733003/1
3 years, 10 months ago (2017-02-23 16:30:03 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 16:35:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/073e0546fc624d92d47dcf4778fd...

Powered by Google App Engine
This is Rietveld 408576698