Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2707043002: [Reading List iOS] Store distillation date and size. (Closed)

Created:
3 years, 10 months ago by Olivier
Modified:
3 years, 10 months ago
Reviewers:
gambard
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reading List iOS] Store distillation date and size. Store distillation size and date in DB. They will be displayed on the Reading List View later. BUG=694451 Review-Url: https://codereview.chromium.org/2707043002 Cr-Commit-Position: refs/heads/master@{#452508} Committed: https://chromium.googlesource.com/chromium/src/+/5ee668e963c93af5171f8a2e53052412c8b6a98a

Patch Set 1 #

Total comments: 3

Patch Set 2 : done #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -32 lines) Patch
M components/reading_list/ios/proto/reading_list.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M components/reading_list/ios/reading_list_entry.h View 1 4 chunks +16 lines, -3 lines 0 comments Download
M components/reading_list/ios/reading_list_entry.cc View 1 11 chunks +47 lines, -5 lines 0 comments Download
M components/reading_list/ios/reading_list_entry_unittest.cc View 1 9 chunks +24 lines, -5 lines 0 comments Download
M components/reading_list/ios/reading_list_model.h View 1 1 chunk +7 lines, -3 lines 0 comments Download
M components/reading_list/ios/reading_list_model_impl.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/reading_list/ios/reading_list_model_impl.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M components/reading_list/ios/reading_list_model_unittest.mm View 1 4 chunks +15 lines, -3 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_download_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_download_service.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/reading_list/url_downloader.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/url_downloader.cc View 5 chunks +18 lines, -3 lines 0 comments Download
M ios/chrome/browser/reading_list/url_downloader_unittest.mm View 1 3 chunks +10 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Olivier
3 years, 10 months ago (2017-02-21 16:30:20 UTC) #2
gambard
Overall, lgtm with nits. https://codereview.chromium.org/2707043002/diff/1/components/reading_list/ios/reading_list_entry_unittest.cc File components/reading_list/ios/reading_list_entry_unittest.cc (right): https://codereview.chromium.org/2707043002/diff/1/components/reading_list/ios/reading_list_entry_unittest.cc#newcode22 components/reading_list/ios/reading_list_entry_unittest.cc:22: int64_t Now() { Nit: I ...
3 years, 10 months ago (2017-02-22 12:30:16 UTC) #3
Olivier
Added image test and move time so RedingListEntry does not depend on the clock. PTAL. ...
3 years, 10 months ago (2017-02-22 14:05:11 UTC) #4
gambard
Thanks for doing that! lgtm
3 years, 10 months ago (2017-02-23 15:44:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707043002/20001
3 years, 10 months ago (2017-02-23 15:45:21 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 16:08:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5ee668e963c93af5171f8a2e5305...

Powered by Google App Engine
This is Rietveld 408576698