Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2706193004: [ObjC ARC] Converts ios/chrome/browser/payments:unit_tests to ARC. (Closed)

Created:
3 years, 10 months ago by stkhapugin
Modified:
3 years, 10 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, sebsg+paymentswatch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/payments:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2706193004 Cr-Commit-Position: refs/heads/master@{#452513} Committed: https://chromium.googlesource.com/chromium/src/+/37fced85ea7c8f784efe85925bff95af50082b36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -92 lines) Patch
M ios/chrome/browser/payments/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/payments/payment_items_display_coordinator_unittest.mm View 4 chunks +19 lines, -18 lines 0 comments Download
M ios/chrome/browser/payments/payment_items_display_view_controller_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/payments/payment_method_selection_coordinator_unittest.mm View 4 chunks +19 lines, -18 lines 0 comments Download
M ios/chrome/browser/payments/payment_method_selection_view_controller_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/payments/payment_request_coordinator_unittest.mm View 6 chunks +19 lines, -20 lines 0 comments Download
M ios/chrome/browser/payments/payment_request_test_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/payments/payment_request_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/payments/payment_request_view_controller_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/payments/shipping_address_selection_coordinator_unittest.mm View 4 chunks +19 lines, -18 lines 0 comments Download
M ios/chrome/browser/payments/shipping_address_selection_view_controller_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/payments/shipping_option_selection_coordinator_unittest.mm View 4 chunks +19 lines, -18 lines 0 comments Download
M ios/chrome/browser/payments/shipping_option_selection_view_controller_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
stkhapugin
PTAL
3 years, 10 months ago (2017-02-22 17:56:16 UTC) #6
sdefresne
lgtm
3 years, 10 months ago (2017-02-23 14:30:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706193004/1
3 years, 10 months ago (2017-02-23 14:42:46 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 16:27:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/37fced85ea7c8f784efe85925bff...

Powered by Google App Engine
This is Rietveld 408576698