Add notification settings button to ARC notifications.

Add notification settings button to ARC notifications.

BUG=b/35260628
TEST=Manual. Check that settings button shows up next to the close
     button.

Review-Url: https://codereview.chromium.org/2704933011
Cr-Commit-Position: refs/heads/master@{#453482}
Committed: https://chromium.googlesource.com/chromium/src/+/033aaecbbe35c9bdeadc2e3a3f9a4641a4e4bd88

[yhanada, 2017-02-24 10:34:57]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 10:35:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 11:51:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 11:51:15]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-02-27 08:39:15]

yhanada@chromium.org changed reviewers:
+ yoshiki@chromium.org

[yhanada, 2017-02-27 08:39:15]

PTAL.

[yhanada, 2017-02-27 08:39:24]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 08:39:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 09:41:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 09:41:45]

Dry run: This issue passed the CQ dry run.

[Peter Beverloo, 2017-02-27 10:09:04]

Other notifications shown by Chrome can have a close button at the bottom-end of
the toast. It would be a bit unfortunate if ARC notifications show up elsewhere.
Could we unify?

(I don't have access to the bug you mention?)

https://developers.google.com/web/updates/images/2016/03/notifications/deskto...

[yoshiki, 2017-02-28 02:29:46]

lgtm

On 2017/02/27 10:09:04, Peter Beverloo wrote:
> Other notifications shown by Chrome can have a close button at the bottom-end
of
> the toast. It would be a bit unfortunate if ARC notifications show up
elsewhere.
> Could we unify?
> 
> (I don't have access to the bug you mention?)
> 
>
https://developers.google.com/web/updates/images/2016/03/notifications/deskto...

We are changing Win and Linux as well (see the issue for context).

Could you check if you can see b/35260628 now? I added you as a CC.

[yhanada, 2017-02-28 03:24:39]

Thank you for reviewing!

[yhanada, 2017-02-28 03:24:44]

The CQ bit was checked by yhanada@chromium.org

[commit-bot: I haz the power, 2017-02-28 03:25:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 03:36:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488252284565390,
"parent_rev": "c850f7a8cb92c40277c4343c03ce2c06be356be8", "commit_rev":
"033aaecbbe35c9bdeadc2e3a3f9a4641a4e4bd88"}

[commit-bot: I haz the power, 2017-02-28 03:37:11]

Description was changed from

==========
Add notification settings button to ARC notifications.

BUG=b/35260628
TEST=Manual. Check that settings button shows up next to the close
     button.
==========

to

==========
Add notification settings button to ARC notifications.

BUG=b/35260628
TEST=Manual. Check that settings button shows up next to the close
     button.

Review-Url: https://codereview.chromium.org/2704933011
Cr-Commit-Position: refs/heads/master@{#453482}
Committed:
https://chromium.googlesource.com/chromium/src/+/033aaecbbe35c9bdeadc2e3a3f9a...
==========

[commit-bot: I haz the power, 2017-02-28 03:37:12]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/033aaecbbe35c9bdeadc2e3a3f9a...