Chromium Code Reviews
Help | Chromium Project | Sign in
(7)

Issue 2703593003: Fix a bug in WebGL2's uniform*() with sub source. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 5 days ago by Zhenyao Mo
Modified:
1 week, 4 days ago
CC:
chromium-reviews, haraken, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug in WebGL2's uniform*() with sub source. BUG=693266 TEST=asan with conformance2/uniforms/* R=kbr@chromium.org,kainino@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2703593003 Cr-Commit-Position: refs/heads/master@{#451356} Committed: https://chromium.googlesource.com/chromium/src/+/ab00bb3e38a097b8e8362fe66d7f62fe82182a81

Patch Set 1 #

Patch Set 2 : Fix a bug in WebGL2's uniform*() with sub source. #

Messages

Total messages: 16 (10 generated)
Zhenyao Mo
Please review. Tested with asan build. Without this, crash; with this, pass. conformance test will ...
1 week, 5 days ago (2017-02-17 00:38:58 UTC) #6
Kai Ninomiya
srcLength is guaranteed to be valid if it passes validateUniformParameters, right? If so, LGTM
1 week, 5 days ago (2017-02-17 02:10:39 UTC) #7
Zhenyao Mo
On 2017/02/17 02:10:39, Kai Ninomiya wrote: > srcLength is guaranteed to be valid if it ...
1 week, 4 days ago (2017-02-17 19:05:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703593003/20001
1 week, 4 days ago (2017-02-17 19:06:26 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ab00bb3e38a097b8e8362fe66d7f62fe82182a81
1 week, 4 days ago (2017-02-17 19:50:36 UTC) #15
Ken Russell
1 week, 4 days ago (2017-02-17 19:58:23 UTC) #16
Message was sent while issue was closed.
Thanks Mo for catching and fixing this bug and Kai for reviewing it.

Let's roll forward the WebGL conformance tests ASAP to get the automated test in
place for this.

LGTM after the fact.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd