Print creator's call-stack on URLRequestContextGetter leak in Debug.

Print creator's call-stack on URLRequestContextGetter leak in Debug.

This adds a StackTrace member to the URLRequestContextGetter base, to
allow the call-stack that created the instance to be printed in case
of it having to be leaked because of the owning thread having gone away.

BUG=693965
Review-Url: https://codereview.chromium.org/2702083002
Cr-Commit-Position: refs/heads/master@{#452289}
Committed: https://chromium.googlesource.com/chromium/src/+/c59596d13ec0e105c72dd69661b8bcb505d9afa7

[Wez, 2017-02-19 00:31:01]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-19 00:31:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-19 01:59:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-19 01:59:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Wez, 2017-02-22 19:43:12]

wez@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Wez, 2017-02-22 19:43:12]

PTAL :)

[Ryan Sleevi, 2017-02-22 19:45:57]

LGTM % question

https://codereview.chromium.org/2702083002/diff/1/net/url_request/url_request...
File net/url_request/url_request_context_getter.cc (right):

https://codereview.chromium.org/2702083002/diff/1/net/url_request/url_request...
net/url_request/url_request_context_getter.cc:43: #if !defined(NDEBUG)
Did you mean to remove this logging for !NDEBUG builds?

[Wez, 2017-02-22 22:18:42]

https://codereview.chromium.org/2702083002/diff/1/net/url_request/url_request...
File net/url_request/url_request_context_getter.cc (right):

https://codereview.chromium.org/2702083002/diff/1/net/url_request/url_request...
net/url_request/url_request_context_getter.cc:43: #if !defined(NDEBUG)
On 2017/02/22 19:45:57, Ryan Sleevi wrote:
> Did you mean to remove this logging for !NDEBUG builds?

This is already a DLOG(), so compiles to a void stream in NDEBUG builds. I
think.

/me runs off to check.

Yup, that is at least what DLOG is documented as doing.

[Wez, 2017-02-22 22:18:46]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2017-02-22 22:19:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 00:04:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487801926937380, "parent_rev":
"8d53bd42d92b6827b6366b5d825ac1a2ec9f0d1f", "commit_rev":
"c59596d13ec0e105c72dd69661b8bcb505d9afa7"}

[commit-bot: I haz the power, 2017-02-23 00:05:44]

Description was changed from

==========
Print creator's call-stack on URLRequestContextGetter leak in Debug.

This adds a StackTrace member to the URLRequestContextGetter base, to
allow the call-stack that created the instance to be printed in case
of it having to be leaked because of the owning thread having gone away.

BUG=693965
==========

to

==========
Print creator's call-stack on URLRequestContextGetter leak in Debug.

This adds a StackTrace member to the URLRequestContextGetter base, to
allow the call-stack that created the instance to be printed in case
of it having to be leaked because of the owning thread having gone away.

BUG=693965

Review-Url: https://codereview.chromium.org/2702083002
Cr-Commit-Position: refs/heads/master@{#452289}
Committed:
https://chromium.googlesource.com/chromium/src/+/c59596d13ec0e105c72dd69661b8...
==========

[commit-bot: I haz the power, 2017-02-23 00:05:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c59596d13ec0e105c72dd69661b8...

[Mathieu, 2017-02-23 16:17:44]

On 2017/02/23 00:05:44, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/c59596d13ec0e105c72dd69661b8...

I know see this stack trace everytime I run interactive browser tests, or
shutting down the ToT browser, giving the impression that the browser/test has
crashed. Intended?

[Wez, 2017-02-23 20:23:13]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2708923008/ by wez@chromium.org.

The reason for reverting is: This output is too noisy on browser shutdown, where
is apparently now expected that we leak things..