Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 2698813008: [OWNERS tags] Check against multiple teams per component on presubmit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 5 days ago by RobertoCN
Modified:
16 hours, 42 minutes ago
CC:
chromium-reviews, sshruthi1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[OWNERS tags] Check against multiple teams per component on presubmit This new check uses the latest automatically generated component map https://storage.googleapis.com/chromium-owners/component_map.json to verify that the change does not introduce multiple teams for the same component. TBR=ymzhang@chromium.org,stgao@chromium.org BUG= Review-Url: https://codereview.chromium.org/2698813008 Cr-Commit-Position: refs/heads/master@{#453784} Committed: https://chromium.googlesource.com/chromium/src/+/e49357eef7a06b04ce632446fc5b3a33757ce9a1

Patch Set 1 #

Total comments: 1

Messages

Total messages: 9 (4 generated)
RobertoCN
Yang, could you please review this change?
1 week, 5 days ago (2017-02-17 03:00:18 UTC) #1
ymzhang1
On 2017/02/17 03:00:18, RobertoCN wrote: > Yang, could you please review this change? Sure.
1 week, 5 days ago (2017-02-17 17:26:39 UTC) #2
ymzhang1
The code looks good to me. Add one comment. https://codereview.chromium.org/2698813008/diff/1/tools/checkteamtags/checkteamtags.py File tools/checkteamtags/checkteamtags.py (right): https://codereview.chromium.org/2698813008/diff/1/tools/checkteamtags/checkteamtags.py#newcode55 tools/checkteamtags/checkteamtags.py:55: ...
1 week, 4 days ago (2017-02-17 21:00:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698813008/1
16 hours, 54 minutes ago (2017-03-01 00:57:40 UTC) #6
commit-bot: I haz the power
16 hours, 42 minutes ago (2017-03-01 01:09:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e49357eef7a06b04ce632446fc5b...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd