Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: content/shell/browser/layout_test/layout_test_push_messaging_service.h

Issue 2697793004: Push API: Validate storage before returning cached subscriptions (Closed)
Patch Set: Comment out PUSH_GETREGISTRATION_STATUS_PUBLIC_KEY_UNAVAILABLE Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_push_messaging_service.h
diff --git a/content/shell/browser/layout_test/layout_test_push_messaging_service.h b/content/shell/browser/layout_test/layout_test_push_messaging_service.h
index 18a59f140f4c4d593eeca5c7c428c0b63e1d127f..536b3755679587b28ad2a96c4d7bba1a19ef654c 100644
--- a/content/shell/browser/layout_test/layout_test_push_messaging_service.h
+++ b/content/shell/browser/layout_test/layout_test_push_messaging_service.h
@@ -26,28 +26,27 @@ class LayoutTestPushMessagingService : public PushMessagingService {
// PushMessagingService implementation:
GURL GetEndpoint(bool standard_protocol) const override;
- void SubscribeFromDocument(
- const GURL& requesting_origin,
- int64_t service_worker_registration_id,
- int renderer_id,
- int render_frame_id,
- const PushSubscriptionOptions& options,
- const PushMessagingService::RegisterCallback& callback) override;
- void SubscribeFromWorker(
- const GURL& requesting_origin,
- int64_t service_worker_registration_id,
- const PushSubscriptionOptions& options,
- const PushMessagingService::RegisterCallback& callback) override;
- void GetEncryptionInfo(
- const GURL& origin,
- int64_t service_worker_registration_id,
- const std::string& sender_id,
- const PushMessagingService::EncryptionInfoCallback& callback) override;
+ void SubscribeFromDocument(const GURL& requesting_origin,
+ int64_t service_worker_registration_id,
+ int renderer_id,
+ int render_frame_id,
+ const PushSubscriptionOptions& options,
+ const RegisterCallback& callback) override;
+ void SubscribeFromWorker(const GURL& requesting_origin,
+ int64_t service_worker_registration_id,
+ const PushSubscriptionOptions& options,
+ const RegisterCallback& callback) override;
+ void GetSubscriptionInfo(const GURL& origin,
+ int64_t service_worker_registration_id,
+ const std::string& sender_id,
+ const std::string& subscription_id,
+ const SubscriptionInfoCallback& callback) override;
blink::WebPushPermissionStatus GetPermissionStatus(const GURL& origin,
bool user_visible)
override;
bool SupportNonVisibleMessages() override;
- void Unsubscribe(const GURL& requesting_origin,
+ void Unsubscribe(PushUnregistrationReason reason,
+ const GURL& requesting_origin,
int64_t service_worker_registration_id,
const std::string& sender_id,
const UnregisterCallback& callback) override;

Powered by Google App Engine
This is Rietveld 408576698