content/public/common/push_messaging_status.cc - Issue 2697793004: Push API: Validate storage before returning cached subscriptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/push_messaging_status.cc

Issue 2697793004: Push API: Validate storage before returning cached subscriptions (Closed)

Patch Set: Comment out PUSH_GETREGISTRATION_STATUS_PUBLIC_KEY_UNAVAILABLE Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/common/push_messaging_status.cc

diff --git a/content/public/common/push_messaging_status.cc b/content/public/common/push_messaging_status.cc

index abee3207eff2ac45fd04b4a11b627257ebf74c73..664ce1632b49bbcc18df8bd9aa24336c5703e353 100644

--- a/content/public/common/push_messaging_status.cc

+++ b/content/public/common/push_messaging_status.cc

@@ -57,6 +57,9 @@ const char* PushRegistrationStatusToString(PushRegistrationStatus status) {

return "Registration failed - A subscription with a different "

"applicationServerKey (or gcm_sender_id) already exists; to "

"change the applicationServerKey, unsubscribe then resubscribe.";

+ case PUSH_REGISTRATION_STATUS_STORAGE_CORRUPT:

+ return "Registration failed - storage corrupt";

}

NOTREACHED();

return "";