WIP: Reland CompiledScript, prototype compiling in a separate task.

third_party/WebKit/Source/core/dom/PendingScript.cpp

 /*
  * Copyright (C) 2010 Google, Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
  * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "core/dom/PendingScript.h"
 
+#include "bindings/core/v8/ScriptController.h"
 #include "bindings/core/v8/ScriptSourceCode.h"
 #include "core/dom/Element.h"
+#include "core/dom/ScriptLoader.h"
+#include "core/dom/TaskRunnerHelper.h"
+#include "core/frame/LocalFrame.h"
 #include "core/frame/SubresourceIntegrity.h"
 #include "platform/SharedBuffer.h"
+#include "platform/instrumentation/tracing/TraceEvent.h"
 #include "wtf/CurrentTime.h"
 
 namespace blink {
 
 PendingScript* PendingScript::create(Element* element,
                                      ScriptResource* resource) {
   return new PendingScript(element, resource, TextPosition());
 }
 
 PendingScript* PendingScript::create(Element* element,
                                      const TextPosition& startingPosition) {
   return new PendingScript(element, nullptr, startingPosition);
 }
 
 PendingScript* PendingScript::createForTesting(ScriptResource* resource) {
   return new PendingScript(nullptr, resource, TextPosition(), true);
 }
 
 PendingScript::PendingScript(Element* element,
                              ScriptResource* resource,
                              const TextPosition& startingPosition,
                              bool isForTesting)
     : m_watchingForLoad(false),
+      m_readyState(resource ? kWaitingForResource : kReady),
       m_element(element),
       m_startingPosition(startingPosition),
       m_integrityFailure(false),
       m_parserBlockingLoadStartTime(0),
       m_client(nullptr),
       m_isForTesting(isForTesting) {
   checkState();
   setResource(resource);
   MemoryCoordinator::instance().registerClient(this);
 }
@@ skipping 27 matching lines @@
 
   DCHECK(!m_watchingForLoad);
   // addClient() will call streamingFinished() if the load is complete. Callers
   // who do not expect to be re-entered from this call should not call
   // watchForLoad for a PendingScript which isReady. We also need to set
   // m_watchingForLoad early, since addClient() can result in calling
   // notifyFinished and further stopWatchingForLoad().
   m_watchingForLoad = true;
   m_client = client;
   if (isReady())
-    m_client->pendingScriptFinished(this);
+    client->pendingScriptFinished(this);
 }
 
 void PendingScript::stopWatchingForLoad() {
   if (!m_watchingForLoad)
     return;
   checkState();
   DCHECK(resource());
   m_client = nullptr;
   m_watchingForLoad = false;
 }
 
 Element* PendingScript::element() const {
   // As mentioned in the comment at |m_element| declaration, |m_element|
   // must points to the corresponding ScriptLoader's element.
   CHECK(m_element);
   return m_element.get();
 }
 
 void PendingScript::streamingFinished() {
   checkState();
   DCHECK(resource());
+  fetchFinished();
+}
+
+void PendingScript::fetchFinished() {
+  advanceReadyState(kWaitingForCompile);
+
+  TRACE_EVENT_WITH_FLOW0("blink", "PendingScript compile", this,
+                         TRACE_EVENT_FLAG_FLOW_OUT);
+  LocalFrame* frame = m_element ? m_element->document().frame() : nullptr;
+  if (!frame) {
+    // TODO(jbroman): A way of telling the client that it failed, without making
+    // the client try again, would be great.
+    compileFinished();
+    return;
+  }
+
+  ScriptState::Scope scope(ScriptState::forMainWorld(frame));
+  bool errorOccurred;
+  ScriptSourceCode sourceCode = getSource(KURL(), errorOccurred);
+
+  if (errorOccurred) {
+    // TODO(jbroman): A way of telling the client that it failed, without making
+    // the client try again, would be great.
+    compileFinished();
+    return;
+  }
+
+  const bool isExternalScript = true;
+  AccessControlStatus accessControlStatus =
+      ScriptLoader::accessControlStatusForScript(
+          isExternalScript, resource(),
+          m_element->document().getSecurityOrigin());
+  m_compiledScript =
+      frame->script().compileScriptInMainWorld(sourceCode, accessControlStatus);
+  // TODO(jbroman): Can this fail? Yes, it can.
+  // CHECK(m_compiledScript) << "no compiled script? :'(";
+  TaskRunnerHelper::get(TaskType::Networking, frame)
+      ->postTask(FROM_HERE, WTF::bind(&PendingScript::compileFinished,
+                                      wrapPersistent(this)));
+}
+
+void PendingScript::compileFinished() {
+  TRACE_EVENT_WITH_FLOW0("blink", "PendingScript compile", this,
+                         TRACE_EVENT_FLAG_FLOW_IN);
+  advanceReadyState(kReady);
   if (m_client)
     m_client->pendingScriptFinished(this);
 }
 
 void PendingScript::markParserBlockingLoadStartTime() {
   DCHECK_EQ(m_parserBlockingLoadStartTime, 0.0);
   m_parserBlockingLoadStartTime = monotonicallyIncreasingTime();
 }
 
 // Returns true if SRI check passed.
@@ skipping 61 matching lines @@
   // the Fetch algorithm, this should be fixed by having separate Response
   // objects (perhaps attached to identical Resource objects) per request.
   //
   // See https://crbug.com/500701 for more information.
   checkState();
   if (m_element)
     m_integrityFailure = !checkScriptResourceIntegrity(resource, m_element);
 
   // If script streaming is in use, the client will be notified in
   // streamingFinished.
-  if (m_streamer)
+  if (m_streamer) {
+    advanceReadyState(kWaitingForStreaming);
     m_streamer->notifyFinished(resource);
-  else if (m_client)
-    m_client->pendingScriptFinished(this);
+  } else {
+    fetchFinished();
+  }
 }
 
 void PendingScript::notifyAppendData(ScriptResource* resource) {
   if (m_streamer)
     m_streamer->notifyAppendData(resource);
 }
 
 DEFINE_TRACE(PendingScript) {
   visitor->trace(m_element);
   visitor->trace(m_streamer);
   visitor->trace(m_client);
+  visitor->trace(m_compiledScript);
   ResourceOwner<ScriptResource>::trace(visitor);
   MemoryCoordinatorClient::trace(visitor);
 }
 
 ScriptSourceCode PendingScript::getSource(const KURL& documentURL,
                                           bool& errorOccurred) const {
   checkState();
 
   errorOccurred = this->errorOccurred();
   if (resource()) {
     DCHECK(resource()->isLoaded());
-    if (m_streamer && !m_streamer->streamingSuppressed())
+    // Avoid consuming the streamed source code more than once.
+    // TODO(jbroman): Update this if we don't always do the precompile step.
+    if (m_streamer && !m_streamer->streamingSuppressed() &&
+        m_readyState < ReadyState::kReady) {
       return ScriptSourceCode(m_streamer, resource());
+    }
     return ScriptSourceCode(resource());
   }
 
   return ScriptSourceCode(m_element->textContent(), documentURL,
                           startingPosition());
 }
 
 void PendingScript::setStreamer(ScriptStreamer* streamer) {
   DCHECK(!m_streamer);
   DCHECK(!m_watchingForLoad);
+  DCHECK(!streamer->isFinished());
+  DCHECK_LT(m_readyState, kWaitingForStreaming);
   m_streamer = streamer;
   checkState();
 }
 
 bool PendingScript::isReady() const {
   checkState();
-  if (resource()) {
-    return resource()->isLoaded() && (!m_streamer || m_streamer->isFinished());
-  }
-
-  return true;
+  return m_readyState == kReady;
 }
 
 bool PendingScript::errorOccurred() const {
   checkState();
   if (resource())
     return resource()->errorOccurred() || m_integrityFailure;
 
   return false;
 }
 
 void PendingScript::onPurgeMemory() {
   checkState();
   if (!m_streamer)
     return;
   m_streamer->cancel();
   m_streamer = nullptr;
 }
 
 }  // namespace blink