Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: components/ntp_tiles/most_visited_sites_unittest.cc

Issue 2695713004: Add baked-in favicons for default popular sites on NTP (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_tiles/most_visited_sites.cc ('k') | components/ntp_tiles/popular_sites.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_tiles/most_visited_sites_unittest.cc
diff --git a/components/ntp_tiles/most_visited_sites_unittest.cc b/components/ntp_tiles/most_visited_sites_unittest.cc
index 0142bad46c121057f09f98857598861a1bd2a259..0a7a5b576d7d75805d8efb22f78b1424affcb7e3 100644
--- a/components/ntp_tiles/most_visited_sites_unittest.cc
+++ b/components/ntp_tiles/most_visited_sites_unittest.cc
@@ -193,9 +193,10 @@ class MockMostVisitedSitesObserver : public MostVisitedSites::Observer {
class MockIconCacher : public IconCacher {
public:
- MOCK_METHOD2(StartFetch,
+ MOCK_METHOD3(StartFetch,
void(PopularSites::Site site,
- const base::Callback<void(bool)>& done));
+ const base::Closure& icon_available,
+ const base::Closure& preliminary_icon_available));
};
class PopularSitesFactoryForTest {
@@ -311,7 +312,7 @@ class MostVisitedSitesTest : public ::testing::TestWithParam<bool> {
.WillRepeatedly(Return(false));
// Mock icon cacher never replies, and we also don't verify whether the
// code uses it correctly.
- EXPECT_CALL(*icon_cacher, StartFetch(_, _)).Times(AtLeast(0));
+ EXPECT_CALL(*icon_cacher, StartFetch(_, _, _)).Times(AtLeast(0));
}
most_visited_sites_ = base::MakeUnique<MostVisitedSites>(
« no previous file with comments | « components/ntp_tiles/most_visited_sites.cc ('k') | components/ntp_tiles/popular_sites.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698