Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: components/ntp_tiles/most_visited_sites.cc

Issue 2695713004: Add baked-in favicons for default popular sites on NTP (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_tiles/most_visited_sites.h ('k') | components/ntp_tiles/most_visited_sites_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_tiles/most_visited_sites.cc
diff --git a/components/ntp_tiles/most_visited_sites.cc b/components/ntp_tiles/most_visited_sites.cc
index f3695c9946ec90bfe44a7e89456e6e539e820fd9..4f7c845a6919c83aafb82aaa57673ad309fc1ec6 100644
--- a/components/ntp_tiles/most_visited_sites.cc
+++ b/components/ntp_tiles/most_visited_sites.cc
@@ -359,9 +359,10 @@ NTPTilesVector MostVisitedSites::CreatePopularSitesTiles(
tile.source = NTPTileSource::POPULAR;
popular_sites_tiles.push_back(std::move(tile));
- icon_cacher_->StartFetch(
- popular_site, base::Bind(&MostVisitedSites::OnIconMadeAvailable,
- base::Unretained(this), popular_site.url));
+ base::Closure icon_available =
+ base::Bind(&MostVisitedSites::OnIconMadeAvailable,
+ base::Unretained(this), popular_site.url);
+ icon_cacher_->StartFetch(popular_site, icon_available, icon_available);
if (popular_sites_tiles.size() >= num_popular_sites_tiles)
break;
}
@@ -420,10 +421,8 @@ void MostVisitedSites::OnPopularSitesDownloaded(bool success) {
}
}
-void MostVisitedSites::OnIconMadeAvailable(const GURL& site_url,
- bool newly_available) {
- if (newly_available)
- observer_->OnIconMadeAvailable(site_url);
+void MostVisitedSites::OnIconMadeAvailable(const GURL& site_url) {
+ observer_->OnIconMadeAvailable(site_url);
}
void MostVisitedSites::TopSitesLoaded(TopSites* top_sites) {}
« no previous file with comments | « components/ntp_tiles/most_visited_sites.h ('k') | components/ntp_tiles/most_visited_sites_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698