ios/chrome/browser/reading_list/reading_list_download_service_factory.cc - Issue 2694333002: Fix leaking page visits in incognito mode via bookmarked favicons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/reading_list/reading_list_download_service_factory.cc

Issue 2694333002: Fix leaking page visits in incognito mode via bookmarked favicons (Closed)

Patch Set: Rebased Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/reading_list/favicon_web_state_dispatcher_impl.mm ('k') | ios/chrome/browser/tabs/tab_helper_util.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/reading_list/reading_list_download_service_factory.cc

diff --git a/ios/chrome/browser/reading_list/reading_list_download_service_factory.cc b/ios/chrome/browser/reading_list/reading_list_download_service_factory.cc

index fb1eba80e5a4c420d0c542105df603c77d3362b7..a724d533c6df0e36678607079a455884ecaf578e 100644

--- a/ios/chrome/browser/reading_list/reading_list_download_service_factory.cc

+++ b/ios/chrome/browser/reading_list/reading_list_download_service_factory.cc

@@ -9,7 +9,6 @@

#include "components/dom_distiller/core/distiller.h"

#include "components/dom_distiller/core/distiller_url_fetcher.h"

#include "components/keyed_service/ios/browser_state_dependency_manager.h"

-#include "ios/chrome/browser/bookmarks/bookmark_model_factory.h"

#include "ios/chrome/browser/browser_state/browser_state_otr_helper.h"

#include "ios/chrome/browser/browser_state/chrome_browser_state.h"

#include "ios/chrome/browser/favicon/favicon_service_factory.h"

@@ -39,7 +38,6 @@ ReadingListDownloadServiceFactory::ReadingListDownloadServiceFactory()

DependsOn(ReadingListModelFactory::GetInstance());

DependsOn(ios::FaviconServiceFactory::GetInstance());

DependsOn(ios::HistoryServiceFactory::GetInstance());

- DependsOn(ios::BookmarkModelFactory::GetInstance());

}

ReadingListDownloadServiceFactory::~ReadingListDownloadServiceFactory() {}

« no previous file with comments | « ios/chrome/browser/reading_list/favicon_web_state_dispatcher_impl.mm ('k') | ios/chrome/browser/tabs/tab_helper_util.mm » ('j') | no next file with comments »