ios/chrome/browser/reading_list/favicon_web_state_dispatcher_impl.mm - Issue 2694333002: Fix leaking page visits in incognito mode via bookmarked favicons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/reading_list/favicon_web_state_dispatcher_impl.mm

Issue 2694333002: Fix leaking page visits in incognito mode via bookmarked favicons (Closed)

Patch Set: Rebased Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/reading_list/BUILD.gn ('k') | ios/chrome/browser/reading_list/reading_list_download_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/reading_list/favicon_web_state_dispatcher_impl.mm

diff --git a/ios/chrome/browser/reading_list/favicon_web_state_dispatcher_impl.mm b/ios/chrome/browser/reading_list/favicon_web_state_dispatcher_impl.mm

index 528c9471d38bb7dc3a7a09bf4f5e6a7697a3bc2c..be698eb569607d80d273a91a26d1b90517cfdf62 100644

--- a/ios/chrome/browser/reading_list/favicon_web_state_dispatcher_impl.mm

+++ b/ios/chrome/browser/reading_list/favicon_web_state_dispatcher_impl.mm

@@ -6,7 +6,6 @@

#include "components/favicon/ios/web_favicon_driver.h"

#include "components/keyed_service/core/service_access_type.h"

-#include "ios/chrome/browser/bookmarks/bookmark_model_factory.h"

#include "ios/chrome/browser/browser_state/chrome_browser_state.h"

#include "ios/chrome/browser/favicon/favicon_service_factory.h"

#include "ios/chrome/browser/history/history_service_factory.h"

@@ -46,8 +45,7 @@ FaviconWebStateDispatcherImpl::RequestWebState() {

ios::FaviconServiceFactory::GetForBrowserState(

original_browser_state, ServiceAccessType::EXPLICIT_ACCESS),

ios::HistoryServiceFactory::GetForBrowserState(

- original_browser_state, ServiceAccessType::EXPLICIT_ACCESS),

- ios::BookmarkModelFactory::GetForBrowserState(original_browser_state));

+ original_browser_state, ServiceAccessType::EXPLICIT_ACCESS));

return web_state;

}