Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: components/favicon/core/favicon_handler_unittest.cc

Issue 2694333002: Fix leaking page visits in incognito mode via bookmarked favicons (Closed)
Patch Set: Rebased Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/favicon_handler.cc ('k') | components/favicon/ios/web_favicon_driver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/favicon_handler_unittest.cc
diff --git a/components/favicon/core/favicon_handler_unittest.cc b/components/favicon/core/favicon_handler_unittest.cc
index 68c104599dd79513fae929b7f21cbde5176a5214..461bbcc3e0d35c9882611836b9a9b5156343a7d1 100644
--- a/components/favicon/core/favicon_handler_unittest.cc
+++ b/components/favicon/core/favicon_handler_unittest.cc
@@ -689,21 +689,6 @@ TEST_F(FaviconHandlerTest, DownloadUnknownFaviconInIncognito) {
ElementsAre(kPageURL, kIconURL16x16));
}
-// Test that the FaviconHandler saves a favicon if the page is bookmarked, even
-// in incognito.
-TEST_F(FaviconHandlerTest, DownloadBookmarkedFaviconInIncognito) {
- ON_CALL(delegate_, IsOffTheRecord()).WillByDefault(Return(true));
- ON_CALL(delegate_, IsBookmarked(kPageURL)).WillByDefault(Return(true));
-
- EXPECT_CALL(favicon_service_, UpdateFaviconMappingsAndFetch(_, _, _, _, _, _))
- .Times(0);
-
- EXPECT_CALL(favicon_service_, SetFavicons(_, kIconURL16x16, _, _));
-
- RunHandlerWithSimpleFaviconCandidates({kIconURL16x16});
- EXPECT_THAT(delegate_.downloads(), ElementsAre(kIconURL16x16));
-}
-
// Test that the icon is redownloaded if the icon cached for the page URL
// expired.
TEST_F(FaviconHandlerTest, RedownloadExpiredPageUrlFavicon) {
« no previous file with comments | « components/favicon/core/favicon_handler.cc ('k') | components/favicon/ios/web_favicon_driver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698