Fix leaking page visits in incognito mode via bookmarked favicons

components/favicon/core/favicon_handler_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/favicon/core/favicon_handler.h"
 
 #include <stddef.h>
 
 #include <map>
 #include <memory>
@@ skipping 671 matching lines @@
   EXPECT_CALL(favicon_service_, SetFavicons(_, _, _, _)).Times(0);
 
   EXPECT_CALL(delegate_, OnFaviconUpdated(_, _, kIconURL16x16, _, _));
 
   RunHandlerWithSimpleFaviconCandidates({kIconURL16x16});
   EXPECT_THAT(delegate_.downloads(), ElementsAre(kIconURL16x16));
   EXPECT_THAT(favicon_service_.fake()->db_requests(),
               ElementsAre(kPageURL, kIconURL16x16));
 }
 
-// Test that the FaviconHandler saves a favicon if the page is bookmarked, even
-// in incognito.
-TEST_F(FaviconHandlerTest, DownloadBookmarkedFaviconInIncognito) {
-  ON_CALL(delegate_, IsOffTheRecord()).WillByDefault(Return(true));
-  ON_CALL(delegate_, IsBookmarked(kPageURL)).WillByDefault(Return(true));
-
-  EXPECT_CALL(favicon_service_, UpdateFaviconMappingsAndFetch(_, _, _, _, _, _))
-      .Times(0);
-
-  EXPECT_CALL(favicon_service_, SetFavicons(_, kIconURL16x16, _, _));
-
-  RunHandlerWithSimpleFaviconCandidates({kIconURL16x16});
-  EXPECT_THAT(delegate_.downloads(), ElementsAre(kIconURL16x16));
-}
-
 // Test that the icon is redownloaded if the icon cached for the page URL
 // expired.
 TEST_F(FaviconHandlerTest, RedownloadExpiredPageUrlFavicon) {
   const GURL kIconURL("http://www.google.com/favicon");
   const SkColor kOldColor = SK_ColorBLUE;
   const SkColor kNewColor = SK_ColorGREEN;
 
   favicon_service_.fake()->Store(
       kPageURL, kIconURL,
       CreateRawBitmapResult(kIconURL, FAVICON, /*expired=*/true,
@@ skipping 1396 matching lines @@
 
   // Complete the download.
   EXPECT_CALL(favicon_service_, SetFavicons(_, kManifestURL2, _, _));
   EXPECT_CALL(delegate_, OnFaviconUpdated(_, _, kManifestURL2, _, _));
   EXPECT_TRUE(delegate_.fake_image_downloader().RunCallbackManually());
   base::RunLoop().RunUntilIdle();
 }
 
 }  // namespace
 }  // namespace favicon