Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: components/favicon/core/favicon_driver_impl.h

Issue 2694333002: Fix leaking page visits in incognito mode via bookmarked favicons (Closed)
Patch Set: Rebased Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/DEPS ('k') | components/favicon/core/favicon_driver_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/favicon_driver_impl.h
diff --git a/components/favicon/core/favicon_driver_impl.h b/components/favicon/core/favicon_driver_impl.h
index 53619f1f0bb32802935ff9a1e871938721f997f6..35dc08f6d869911a618ed9fced75f52415d4a396 100644
--- a/components/favicon/core/favicon_driver_impl.h
+++ b/components/favicon/core/favicon_driver_impl.h
@@ -13,10 +13,6 @@
#include "components/favicon/core/favicon_handler.h"
class GURL;
-namespace bookmarks {
-class BookmarkModel;
-}
-
namespace history {
class HistoryService;
@@ -40,17 +36,13 @@ class FaviconDriverImpl : public FaviconDriver,
// FaviconDriver implementation.
void FetchFavicon(const GURL& page_url, bool is_same_document) override;
- // FaviconHandler::Delegate implementation.
- bool IsBookmarked(const GURL& url) override;
-
// Returns whether the driver is waiting for a download to complete or for
// data from the FaviconService. Reserved for testing.
bool HasPendingTasksForTest();
protected:
FaviconDriverImpl(FaviconService* favicon_service,
- history::HistoryService* history_service,
- bookmarks::BookmarkModel* bookmark_model);
+ history::HistoryService* history_service);
~FaviconDriverImpl() override;
// Informs FaviconService that the favicon for |url| is out of date. If
@@ -73,7 +65,6 @@ class FaviconDriverImpl : public FaviconDriver,
// but if they are defined, they must outlive the FaviconDriverImpl.
FaviconService* favicon_service_;
history::HistoryService* history_service_;
- bookmarks::BookmarkModel* bookmark_model_;
// FaviconHandlers used to download the different kind of favicons.
std::vector<std::unique_ptr<FaviconHandler>> handlers_;
« no previous file with comments | « components/favicon/core/DEPS ('k') | components/favicon/core/favicon_driver_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698