Use OS_LINUX instead of USE_OZONE in ui/gfx/ when possible

Use OS_LINUX instead of USE_OZONE in ui/gfx/ when possible

This code is perfectly valid on any linux platform.

And required as a pre-step to enable glCreateImageCHROMIUM
with linux dma buf on OS_LINUX.

BUG=584248
R=reveman@chromium.org

Review-Url: https://codereview.chromium.org/2683593006
Cr-Commit-Position: refs/heads/master@{#455710}
Committed: https://chromium.googlesource.com/chromium/src/+/ca3ea42526a3541f6b54b0fef9104a28471438b9

[Julien Isorce, 2017-02-23 13:58:36]

Hi David, please take a look. Thx.

[Julien Isorce, 2017-02-23 15:19:01]

The CQ bit was checked by julien.isorce@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 15:19:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 16:08:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 16:08:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Julien Isorce, 2017-02-23 16:35:43]

The CQ bit was checked by julien.isorce@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 16:36:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reveman, 2017-02-23 17:34:20]

lgtm

[commit-bot: I haz the power, 2017-02-23 18:14:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 18:14:57]

Dry run: This issue passed the CQ dry run.

[Julien Isorce, 2017-03-07 16:59:06]

Description was changed from

==========
Use OS_LINUX instead of USE_OZONE in ui/gfx/ when possible

This code is perfectly valid on any linux platform.

And required as a pre-step to enable glCreateImageCHROMIUM
with linux dma buf on OS_LINUX.

BUG=584248
R=reveman@chromium.org
==========

to

==========
Use OS_LINUX instead of USE_OZONE in ui/gfx/ when possible

This code is perfectly valid on any linux platform.

And required as a pre-step to enable glCreateImageCHROMIUM
with linux dma buf on OS_LINUX.

BUG=584248
R=reveman@chromium.org
==========

[Julien Isorce, 2017-03-07 16:59:06]

julien.isorce@chromium.org changed reviewers:
+ sadrul@chromium.org

[Julien Isorce, 2017-03-07 16:59:30]

** Presubmit Messages **
Missing OWNER reviewers for these files:
    ui/gfx/ipc/gfx_param_traits_macros.h
    ui/gfx/mojo/buffer_types_struct_traits.cc
    ui/gfx/mojo/buffer_types_struct_traits.h
    ui/gfx/mojo/struct_traits_unittest.cc
    ui/gfx/native_pixmap_handle.cc
    ui/gfx/native_pixmap_handle.h

Hi sadrul@, please take a look. Thx!

[Julien Isorce, 2017-03-07 17:41:54]

The CQ bit was checked by julien.isorce@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 17:42:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 18:52:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 18:52:27]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-03-08 02:06:26]

sadrul@chromium.org changed reviewers:
+ tsepez@chromium.org

[sadrul, 2017-03-08 02:06:27]

lgtm But you actually need security review. +tsepez@

[Tom Sepez, 2017-03-08 17:10:51]

lgtm

[Julien Isorce, 2017-03-08 18:21:29]

The CQ bit was checked by julien.isorce@chromium.org

[Julien Isorce, 2017-03-08 18:21:29]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2683593006/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-08 18:21:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 19:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 19:29:40]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Julien Isorce, 2017-03-08 22:31:47]

On 2017/03/08 19:29:40, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
> (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

I doubled check the CL to see if it could be to because of a recent USE_ZONE
that I missed during
rebase but it does not seem to be the case.
It seems that the failure happens with other CL randomly and with random
content_browsertests
but with the same backtrace.

BrowserTestBase received signal: Terminated. Backtrace:
#0 0x000002352f47 base::debug::StackTrace::StackTrace()
#1 0x000001f2fdf6 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7ff9bb2cfcb0 <unknown>
#3 0x7ff9be99a402 __pthread_cond_wait
#4 0x00000239d287 base::ConditionVariable::Wait()
#5 0x00000201ef18 mojo::edk::Waiter::Wait()
#6 0x000001fff254 mojo::edk::Core::WaitManyInternal()
#7 0x000001ffee66 mojo::edk::Core::Wait()

But more often it all succeeds and it passed these tests in Patch Set 3 dry run
so I am having another try.

[Julien Isorce, 2017-03-08 22:32:20]

The CQ bit was checked by julien.isorce@chromium.org

[commit-bot: I haz the power, 2017-03-08 22:33:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 23:36:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 23:36:06]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2017-03-09 07:11:40]

On 2017/03/08 22:31:47, Julien Isorce wrote:
> On 2017/03/08 19:29:40, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
> > (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> 
> I doubled check the CL to see if it could be to because of a recent USE_ZONE
> that I missed during
> rebase but it does not seem to be the case.
> It seems that the failure happens with other CL randomly and with random
> content_browsertests
> but with the same backtrace.
> 
> BrowserTestBase received signal: Terminated. Backtrace:
> #0 0x000002352f47 base::debug::StackTrace::StackTrace()
> #1 0x000001f2fdf6 content::(anonymous
namespace)::DumpStackTraceSignalHandler()
> #2 0x7ff9bb2cfcb0 <unknown>
> #3 0x7ff9be99a402 __pthread_cond_wait
> #4 0x00000239d287 base::ConditionVariable::Wait()
> #5 0x00000201ef18 mojo::edk::Waiter::Wait()
> #6 0x000001fff254 mojo::edk::Core::WaitManyInternal()
> #7 0x000001ffee66 mojo::edk::Core::Wait()
> 
> But more often it all succeeds and it passed these tests in Patch Set 3 dry
run
> so I am having another try.

I think that bot has become a little flaky in the last few hours. I have
triggered yet another run on the bot.

[Julien Isorce, 2017-03-09 08:53:23]

The CQ bit was checked by julien.isorce@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 08:53:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 09:43:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 09:43:31]

Dry run: This issue passed the CQ dry run.

[Julien Isorce, 2017-03-09 09:44:29]

The CQ bit was checked by julien.isorce@chromium.org

[Julien Isorce, 2017-03-09 09:44:29]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
reveman@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2683593006/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-09 09:44:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 11:10:53]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489052669361360,
"parent_rev": "11b13107b7af731540d2042447b43e4d1b498c2a", "commit_rev":
"d4d3135248bec1c3aab8ee653c7c0825ae953768"}

[commit-bot: I haz the power, 2017-03-09 11:15:12]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489052669361360,
"parent_rev": "44befe2158754becde45c5a07519f5d72aca54a9", "commit_rev":
"ca3ea42526a3541f6b54b0fef9104a28471438b9"}

[commit-bot: I haz the power, 2017-03-09 11:15:57]

Description was changed from

==========
Use OS_LINUX instead of USE_OZONE in ui/gfx/ when possible

This code is perfectly valid on any linux platform.

And required as a pre-step to enable glCreateImageCHROMIUM
with linux dma buf on OS_LINUX.

BUG=584248
R=reveman@chromium.org
==========

to

==========
Use OS_LINUX instead of USE_OZONE in ui/gfx/ when possible

This code is perfectly valid on any linux platform.

And required as a pre-step to enable glCreateImageCHROMIUM
with linux dma buf on OS_LINUX.

BUG=584248
R=reveman@chromium.org

Review-Url: https://codereview.chromium.org/2683593006
Cr-Commit-Position: refs/heads/master@{#455710}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca3ea42526a3541f6b54b0fef910...
==========

[commit-bot: I haz the power, 2017-03-09 11:15:59]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/ca3ea42526a3541f6b54b0fef910...