Chromium Code Reviews
Help | Chromium Project | Sign in
(21)

Issue 2677443002: [ObjC ARC] Converts ios/chrome/browser/ui/bookmarks/bars:bars to ARC.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 6 days ago by stkhapugin
Modified:
1 week, 5 days ago
Reviewers:
noyau
CC:
chromium-reviews, marq+watch_chromium.org, tfarina, pklpkl, noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks/bars:bars to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None

Patch Set 1 #

Total comments: 2

Patch Set 2 : asdf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -64 lines) Patch
M ios/chrome/browser/ui/bookmarks/bars/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bars/bookmark_editing_bar.mm View 8 chunks +25 lines, -25 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bars/bookmark_navigation_bar.mm View 8 chunks +23 lines, -26 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bars/bookmark_top_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/bookmarks/bars/bookmark_top_bar.mm View 1 2 chunks +5 lines, -12 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (9 generated)
stkhapugin
ptal
3 weeks, 6 days ago (2017-02-02 14:41:08 UTC) #4
noyau
https://codereview.chromium.org/2677443002/diff/1/ios/chrome/browser/ui/bookmarks/bars/bookmark_top_bar.mm File ios/chrome/browser/ui/bookmarks/bars/bookmark_top_bar.mm (right): https://codereview.chromium.org/2677443002/diff/1/ios/chrome/browser/ui/bookmarks/bars/bookmark_top_bar.mm#newcode12 ios/chrome/browser/ui/bookmarks/bars/bookmark_top_bar.mm:12: @property(nonatomic, strong) UIView* contentView; The only place the content ...
3 weeks, 5 days ago (2017-02-03 12:24:24 UTC) #7
stkhapugin
1 week, 5 days ago (2017-02-17 14:15:48 UTC) #8
ptal

https://codereview.chromium.org/2677443002/diff/1/ios/chrome/browser/ui/bookm...
File ios/chrome/browser/ui/bookmarks/bars/bookmark_top_bar.mm (right):

https://codereview.chromium.org/2677443002/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/bars/bookmark_top_bar.mm:12:
@property(nonatomic, strong) UIView* contentView;
On 2017/02/03 12:24:24, noyau wrote:
> The only place the content view is assigned is in init. Is the redefinition of
> the property really needed? I would assign the instance variable directly.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd