Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 2671813006: [tracing] Defer setting model until timeline-view is attached (Closed)

Created:
2 years, 5 months ago by hjd
Modified:
1 year, 9 months ago
Reviewers:
benjhayden
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[tracing] Defer setting model until timeline-view is attached Setting the model on tr-ui-timeline-view before the element is attached causes a crash, this happens (for example) if we open a trace then quickly switch away to another tab. BUG=catapult:#3184

Patch Set 1 #

Patch Set 2 : defer setting model until attached #

Patch Set 3 : reset trace_viewer.html #

Patch Set 4 : reset trace_viewer.html for real #

Patch Set 5 : set model on timeline-view #

Total comments: 1

Patch Set 6 : remove trackViewModel_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M tracing/tracing/ui/timeline_view.html View 1 2 3 4 5 3 chunks +22 lines, -13 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
hjd
ptal, thanks :)
2 years, 5 months ago (2017-02-10 12:36:04 UTC) #3
benjhayden
On 2017/02/10 at 12:36:04, hjd wrote: > ptal, thanks :) I think that the right ...
2 years, 5 months ago (2017-02-10 17:26:13 UTC) #4
hjd
On 2017/02/10 17:26:13, benjhayden wrote: > On 2017/02/10 at 12:36:04, hjd wrote: > > ptal, ...
2 years, 5 months ago (2017-02-13 12:16:45 UTC) #6
benjhayden
On 2017/02/13 at 12:16:45, hjd wrote: > On 2017/02/10 17:26:13, benjhayden wrote: > > On ...
2 years, 5 months ago (2017-02-15 20:58:50 UTC) #7
hjd
On 2017/02/15 20:58:50, benjhayden wrote: > On 2017/02/13 at 12:16:45, hjd wrote: > > On ...
2 years, 5 months ago (2017-02-15 21:59:35 UTC) #8
benjhayden
On 2017/02/15 at 21:59:35, hjd wrote: > On 2017/02/15 20:58:50, benjhayden wrote: > > On ...
2 years, 5 months ago (2017-02-17 22:52:59 UTC) #9
benjhayden
1 nit then lgtm if you're happy with it :-) https://codereview.chromium.org/2671813006/diff/80001/tracing/tracing/ui/timeline_view.html File tracing/tracing/ui/timeline_view.html (right): https://codereview.chromium.org/2671813006/diff/80001/tracing/tracing/ui/timeline_view.html#newcode385 ...
2 years, 4 months ago (2017-02-22 19:59:31 UTC) #10
hjd
On 2017/02/22 19:59:31, benjhayden wrote: > 1 nit then lgtm if you're happy with it ...
2 years, 4 months ago (2017-02-22 20:15:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671813006/100001
2 years, 4 months ago (2017-02-22 20:16:04 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Mac%20Tryserver/builds/6702)
2 years, 4 months ago (2017-02-22 20:32:14 UTC) #16
hjd
2 years, 4 months ago (2017-02-27 12:21:50 UTC) #17
On 2017/02/22 20:32:14, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[Note to self: Landing is blocked on fixing a test, see
https://github.com/catapult-project/catapult/issues/3297]

Powered by Google App Engine
This is Rietveld 408576698