[Omaha] Move most functionality to OmahaBase, add JobService

[Omaha] Move most functionality to OmahaBase, add JobService

* Move almost all pipeline functionality from OmahaClient to OmahaBase.
  Most of the code changes are strictly code moves, except for a change
  to make it easier to change what Delegate is being used.

* Add a JobScheduler version of the OmahaClient IntentService called
  OmahaClientJobService.  OmahaClient can't be renamed because we may
  potentially have outstanding alarms on the system that reference it.

* Make OmahaClient be the IntentService that is triggered on Android L
  and lower, and OmahaClientJobScheduler be triggered on M and higher.

BUG=680817
Review-Url: https://codereview.chromium.org/2664253005
Cr-Commit-Position: refs/heads/master@{#453504}
Committed: https://chromium.googlesource.com/chromium/src/+/272eb7b955d8008142f9fd6615cea25161f684ac

[gone, 2017-02-03 19:52:42]

Description was changed from

==========
[Omaha] Move most functionality to OmahaBase

Move almost all functionality from OmahaClient to OmahaBase in preparation
for making a JobService equivalent.  Most of the code changes are strictly
code moves, except for a change to make it easier to change what Delegate
is being used.  This *might* be needed for the switch to JobScheduler.

BUG=680817
==========

to

==========
[Omaha] Move most functionality to OmahaBase, add JobService
    
* Move almost all pipeline functionality from OmahaClient to OmahaBase.
  Most of the code changes are strictly code moves, except for a change
  to make it easier to change what Delegate is being used.
    
* Add a JobScheduler version of the OmahaClient IntentService called
  OmahaClientJobService.  OmahaClient can't be renamed because we may
  potentially have outstanding alarms on the system that reference it.
    
* Make OmahaClient be the IntentService that is triggered on Android L
  and lower, and OmahaClientJobScheduler be triggered on M and higher.
    
BUG=680817
==========

[gone, 2017-02-03 19:53:10]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 19:53:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2017-02-03 20:00:09]

dfalcantara@chromium.org changed reviewers:
+ nyquist@chromium.org

[gone, 2017-02-03 20:00:10]

The bulk of the CL is really just a whole lot of code moving around, and
OmahaClientTest being renamed OmahaBaseTest.

[commit-bot: I haz the power, 2017-02-03 20:56:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 20:56:19]

Dry run: This issue passed the CQ dry run.

[gone, 2017-02-08 02:28:54]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 02:29:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2017-02-08 02:29:47]

WDYT of the general structure of the last patch, Tommy?  Still need to test it,
but after moving hundreds of lines of code around, I think this is about as
clean as it gets.

[commit-bot: I haz the power, 2017-02-08 03:48:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 03:48:33]

Dry run: This issue passed the CQ dry run.

[nyquist, 2017-02-14 09:29:21]

This looks great! I'll aim to do what we discussed offline regarding the
background service package to see if we can get it as a component. But that
shouldn't require a lot of follow-up for this CL.

[gone, 2017-02-27 08:25:49]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 08:26:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2017-02-27 08:30:08]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 08:30:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2017-02-27 08:32:50]

Letting this run overnight, but it seems to be working with your new thing.  I
don't think I left any logs in; PTAL.

[commit-bot: I haz the power, 2017-02-27 09:04:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 09:04:25]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[gone, 2017-02-27 17:51:29]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 17:51:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 19:17:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 19:17:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gone, 2017-02-27 19:33:42]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 19:34:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 21:08:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 21:08:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gone, 2017-02-27 21:14:05]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 21:14:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2017-02-27 22:24:30]

Looks like the bots are finally happy. PTAL when you get a chance.

[commit-bot: I haz the power, 2017-02-27 22:44:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 22:44:09]

Dry run: This issue passed the CQ dry run.

[nyquist, 2017-02-28 00:23:00]

lgtm

https://codereview.chromium.org/2664253005/diff/160001/chrome/android/java/DEPS
File chrome/android/java/DEPS (right):

https://codereview.chromium.org/2664253005/diff/160001/chrome/android/java/DE...
chrome/android/java/DEPS:3:
"+components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler",
FYI: Also added in https://codereview.chromium.org/2722503004/

https://codereview.chromium.org/2664253005/diff/160001/chrome/android/java/sr...
File chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaService.java
(right):

https://codereview.chromium.org/2664253005/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaService.java:28:
public static final int OMAHA_JOB_ID = 0x00011684;
Could you move this to
org.chromium.components.background_task_scheduler.TaskIds?

[gone, 2017-02-28 00:35:14]

https://codereview.chromium.org/2664253005/diff/160001/chrome/android/java/DEPS
File chrome/android/java/DEPS (right):

https://codereview.chromium.org/2664253005/diff/160001/chrome/android/java/DE...
chrome/android/java/DEPS:3:
"+components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler",
On 2017/02/28 00:23:00, nyquist wrote:
> FYI: Also added in https://codereview.chromium.org/2722503004/

Acknowledged.

https://codereview.chromium.org/2664253005/diff/160001/chrome/android/java/sr...
File chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaService.java
(right):

https://codereview.chromium.org/2664253005/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaService.java:28:
public static final int OMAHA_JOB_ID = 0x00011684;
On 2017/02/28 00:23:00, nyquist wrote:
> Could you move this to
> org.chromium.components.background_task_scheduler.TaskIds?

Done.

[gone, 2017-02-28 00:39:27]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2017-02-28 00:39:28]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/2664253005/#ps180001
(title: "[Omaha] Move most functionality to OmahaBase, add JobService")

[commit-bot: I haz the power, 2017-02-28 00:39:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 02:56:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 02:57:02]

Failed to apply patch for chrome/android/java/DEPS:
While running git apply --index -p1;
  error: patch failed: chrome/android/java/DEPS:1
  error: chrome/android/java/DEPS: patch does not apply

Patch:       chrome/android/java/DEPS
Index: chrome/android/java/DEPS
diff --git a/chrome/android/java/DEPS b/chrome/android/java/DEPS
index
c6ec049d9fd92e0b5db02ec62b7aee2fe6312f10..8c434f90f8f274fea473dac3ed786c8c960e3387
100644
--- a/chrome/android/java/DEPS
+++ b/chrome/android/java/DEPS
@@ -1,5 +1,6 @@
 include_rules = [
   "+components/autofill/android/java/src/org/chromium/components/autofill",
+ 
"+components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler",
  
"+components/bookmarks/common/android/java/src/org/chromium/components/bookmarks",
  
"+components/dom_distiller/content/browser/android/java/src/org/chromium/components/dom_distiller/content",
  
"+components/dom_distiller/core/android/java/src/org/chromium/components/dom_distiller/core",

[gone, 2017-02-28 03:28:19]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2017-02-28 03:28:20]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/2664253005/#ps200001
(title: "[Omaha] Move most functionality to OmahaBase, add JobService")

[commit-bot: I haz the power, 2017-02-28 03:29:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 05:01:36]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1488252499989940,
"parent_rev": "740c6ef6925014d1af97e3470ffed3b9c3625cf5", "commit_rev":
"272eb7b955d8008142f9fd6615cea25161f684ac"}

[commit-bot: I haz the power, 2017-02-28 05:08:29]

Description was changed from

==========
[Omaha] Move most functionality to OmahaBase, add JobService
    
* Move almost all pipeline functionality from OmahaClient to OmahaBase.
  Most of the code changes are strictly code moves, except for a change
  to make it easier to change what Delegate is being used.
    
* Add a JobScheduler version of the OmahaClient IntentService called
  OmahaClientJobService.  OmahaClient can't be renamed because we may
  potentially have outstanding alarms on the system that reference it.
    
* Make OmahaClient be the IntentService that is triggered on Android L
  and lower, and OmahaClientJobScheduler be triggered on M and higher.
    
BUG=680817
==========

to

==========
[Omaha] Move most functionality to OmahaBase, add JobService

* Move almost all pipeline functionality from OmahaClient to OmahaBase.
  Most of the code changes are strictly code moves, except for a change
  to make it easier to change what Delegate is being used.

* Add a JobScheduler version of the OmahaClient IntentService called
  OmahaClientJobService.  OmahaClient can't be renamed because we may
  potentially have outstanding alarms on the system that reference it.

* Make OmahaClient be the IntentService that is triggered on Android L
  and lower, and OmahaClientJobScheduler be triggered on M and higher.

BUG=680817

Review-Url: https://codereview.chromium.org/2664253005
Cr-Commit-Position: refs/heads/master@{#453504}
Committed:
https://chromium.googlesource.com/chromium/src/+/272eb7b955d8008142f9fd6615ce...
==========

[commit-bot: I haz the power, 2017-02-28 05:08:31]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/272eb7b955d8008142f9fd6615ce...