Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: components/policy/tools/template_writers/writers/adml_writer.py

Issue 2653823006: Include 'external' policies in grit output (admx, adm, doc etc.) (Closed)
Patch Set: Whitespace fix Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/tools/template_writers/writers/adml_writer.py
diff --git a/components/policy/tools/template_writers/writers/adml_writer.py b/components/policy/tools/template_writers/writers/adml_writer.py
index 3d074e8a7c7d405504dfaa0016b510dfe20d92a8..4c30609eaac5f8d808fe331e18b6283064f6b0ab 100755
--- a/components/policy/tools/template_writers/writers/adml_writer.py
+++ b/components/policy/tools/template_writers/writers/adml_writer.py
@@ -88,8 +88,9 @@ class ADMLWriter(xml_formatted_writer.XMLFormattedWriter):
if policy_type == 'main':
pass
- elif policy_type in ('string', 'dict'):
- # 'dict' policies are configured as JSON-encoded strings on Windows.
+ elif policy_type in ('string', 'dict', 'external'):
+ # 'dict' and 'external' policies are configured as JSON-encoded strings on
+ # Windows.
textbox_elem = self.AddElement(presentation_elem, 'textBox',
{'refId': policy_name})
label_elem = self.AddElement(textbox_elem, 'label')
@@ -111,9 +112,6 @@ class ADMLWriter(xml_formatted_writer.XMLFormattedWriter):
listbox_elem.appendChild(self._doc.createTextNode(policy_label))
elif policy_type == 'group':
pass
- elif policy_type == 'external':
- # This type can only be set through cloud policy.
- pass
else:
raise Exception('Unknown policy type %s.' % policy_type)

Powered by Google App Engine
This is Rietveld 408576698