cr-network-icon: Animate connecting using .svg

cr-network-icon: Animate connecting using .svg

BUG=653425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2648843002
Cr-Commit-Position: refs/heads/master@{#445291}
Committed: https://chromium.googlesource.com/chromium/src/+/ac3b36a8e91405bedccaa90e221b784c26cbadb5

[stevenjb, 2017-01-20 22:54:32]

Description was changed from

==========
cr-network-icon: Animate connecting using .svg

BUG=653425
==========

to

==========
cr-network-icon: Animate connecting using .svg

BUG=653425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-01-20 22:59:28]

stevenjb@chromium.org changed reviewers:
+ alemate@chromium.org, dbeam@chromium.org

[stevenjb, 2017-01-20 22:59:28]

This is a CSS based alternative to https://codereview.chromium.org/2647573002/

I haven't noticed any visual difference between the two approaches. CSS may be
smoother on slower machines, especially under heavy load, but I expect there may
be extra load overhead for the individual svg files, perhaps there is a better
way to load them?

[Dan Beam, 2017-01-20 23:24:16]

lgtm

https://codereview.chromium.org/2648843002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/network/cr_network_icon.html (right):

https://codereview.chromium.org/2648843002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/network/cr_network_icon.html:123: 100% {
background: url(cellular_4.svg); }
i think it an ideal world, you'd have less images and just clip them

that's assuming these look like a building histogram or something.  you'd just
add a bar for each level by extending the clip.

oh well

https://codereview.chromium.org/2648843002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements_resources.grdp (right):

https://codereview.chromium.org/2648843002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements_resources.grdp:47: type="chrome_html" />
can you make these type="BINDATA"?

[stevenjb, 2017-01-20 23:44:46]

On 2017/01/20 23:24:16, Dan Beam (slow - converging) wrote:
> lgtm
> 
>
https://codereview.chromium.org/2648843002/diff/1/ui/webui/resources/cr_eleme...
> File ui/webui/resources/cr_elements/network/cr_network_icon.html (right):
> 
>
https://codereview.chromium.org/2648843002/diff/1/ui/webui/resources/cr_eleme...
> ui/webui/resources/cr_elements/network/cr_network_icon.html:123: 100% {
> background: url(cellular_4.svg); }
> i think it an ideal world, you'd have less images and just clip them
> 
> that's assuming these look like a building histogram or something.  you'd just
> add a bar for each level by extending the clip.
> 
That might work for cellular, but wifi is an arc so would be more challenging. I
think that falls into the 'someday, maybe' category...

[stevenjb, 2017-01-20 23:44:53]

https://codereview.chromium.org/2648843002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements_resources.grdp (right):

https://codereview.chromium.org/2648843002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements_resources.grdp:47: type="chrome_html" />
On 2017/01/20 23:24:16, Dan Beam (slow - converging) wrote:
> can you make these type="BINDATA"?

Done.

[stevenjb, 2017-01-20 23:53:44]

On 2017/01/20 23:44:53, stevenjb wrote:
>
https://codereview.chromium.org/2648843002/diff/1/ui/webui/resources/cr_eleme...
> File ui/webui/resources/cr_elements_resources.grdp (right):
> 
>
https://codereview.chromium.org/2648843002/diff/1/ui/webui/resources/cr_eleme...
> ui/webui/resources/cr_elements_resources.grdp:47: type="chrome_html" />
> On 2017/01/20 23:24:16, Dan Beam (slow - converging) wrote:
> > can you make these type="BINDATA"?
> 
> Done.

Actually, BINDATA doesn't work:

KeyError: u'BINDATA'

Suggestions?

[stevenjb, 2017-01-21 00:05:00]

On 2017/01/20 23:53:44, stevenjb wrote:
> On 2017/01/20 23:44:53, stevenjb wrote:
> >
>
https://codereview.chromium.org/2648843002/diff/1/ui/webui/resources/cr_eleme...
> > File ui/webui/resources/cr_elements_resources.grdp (right):
> > 
> >
>
https://codereview.chromium.org/2648843002/diff/1/ui/webui/resources/cr_eleme...
> > ui/webui/resources/cr_elements_resources.grdp:47: type="chrome_html" />
> > On 2017/01/20 23:24:16, Dan Beam (slow - converging) wrote:
> > > can you make these type="BINDATA"?
> > 
> > Done.
> 
> Actually, BINDATA doesn't work:
> 
> KeyError: u'BINDATA'
> 
> Suggestions?

nm, figured it out. Need to convert them to <include> and move them to the
<includes> section. Testing.

[stevenjb, 2017-01-21 00:05:05]

Patchset #2 (id:20001) has been deleted

[stevenjb, 2017-01-21 00:09:39]

The CQ bit was checked by stevenjb@chromium.org to run a CQ dry run

[stevenjb, 2017-01-21 00:09:45]

PTAL

[commit-bot: I haz the power, 2017-01-21 00:09:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-01-21 00:42:21]

sweet, beat me to explaining the structure -> include switch

thanks, still lgtm

[commit-bot: I haz the power, 2017-01-21 01:39:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 01:39:19]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2017-01-21 19:06:26]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-01-21 19:06:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 19:14:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485025586128130,
"parent_rev": "be16140bd84a88c0ee4afee088730c54e02ce78e", "commit_rev":
"ac3b36a8e91405bedccaa90e221b784c26cbadb5"}

[commit-bot: I haz the power, 2017-01-21 19:15:11]

Description was changed from

==========
cr-network-icon: Animate connecting using .svg

BUG=653425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cr-network-icon: Animate connecting using .svg

BUG=653425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2648843002
Cr-Commit-Position: refs/heads/master@{#445291}
Committed:
https://chromium.googlesource.com/chromium/src/+/ac3b36a8e91405bedccaa90e221b...
==========

[commit-bot: I haz the power, 2017-01-21 19:15:12]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ac3b36a8e91405bedccaa90e221b...