Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 2647703006: Move PresentationAttributeCacheCleaner timer to main thread's timer task runner. (Closed)

Created:
3 years, 11 months ago by jbroman
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PresentationAttributeCacheCleaner timer to main thread's timer task runner. This is shared by multiple frames in the renderer main thread. Conceptually it's UnspecedTimer, but since it's not associated with any particular frame, and we know it will be used on the main thread, we can just use the main thread's timer task queue. BUG=624694 Review-Url: https://codereview.chromium.org/2647703006 Cr-Commit-Position: refs/heads/master@{#445277} Committed: https://chromium.googlesource.com/chromium/src/+/7ca861148c5375e15b85831ee2826a818d682c93

Patch Set 1 #

Patch Set 2 : add a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/PresentationAttributeStyle.cpp View 1 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jbroman
There's only one of these (held by DEFINE_STATIC_LOCAL). Continuing to use the thread's timer task ...
3 years, 11 months ago (2017-01-20 20:50:30 UTC) #4
haraken
LGTM Shall we add a comment about it?
3 years, 11 months ago (2017-01-21 01:43:27 UTC) #7
jbroman
On 2017/01/21 at 01:43:27, haraken wrote: > LGTM > > Shall we add a comment ...
3 years, 11 months ago (2017-01-21 05:14:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647703006/20001
3 years, 11 months ago (2017-01-21 05:19:22 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 07:03:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7ca861148c5375e15b85831ee282...

Powered by Google App Engine
This is Rietveld 408576698