Fix how we constrain width/height by min/max

Fix how we constrain width/height by min/max

According to the spec:
- if min/max change the computed length, the algorithm should run
again with length being the clamped length value.

This also fixes a single failing test.

BUG=635619
Review-Url: https://codereview.chromium.org/2645863005
Cr-Commit-Position: refs/heads/master@{#445267}
Committed: https://chromium.googlesource.com/chromium/src/+/0e7df9ebd6385e1f02a328f864c8bff48eb5cbeb

[atotic, 2017-01-20 23:57:16]

atotic@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[atotic, 2017-01-20 23:57:29]

ptal

[atotic, 2017-01-20 23:57:47]

Description was changed from

==========
Fix how we constrain width/height by min/max

According to the spec:
- if min/max change the computed length, the algorithm should run
again with length being the clamped length value.

BUG=635619
==========

to

==========
Fix how we constrain width/height by min/max

According to the spec:
- if min/max change the computed length, the algorithm should run
again with length being the clamped length value.

This also fixes a single failing test.

BUG=635619
==========

[cbiesinger, 2017-01-21 00:03:30]

lgtm

https://codereview.chromium.org/2645863005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc (right):

https://codereview.chromium.org/2645863005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:200:
ComputeAbsoluteHorizontal(space, style, width, static_position,
Can you add a comment on why it's safe to call this function recursively?
Something like:
// Because this function only changes "width" when it's not already
// set, it is safe to recursively call ourselves here because on the
// second call it is guaranteed to be within min..max.

[atotic, 2017-01-21 00:08:52]

The CQ bit was checked by atotic@chromium.org

[atotic, 2017-01-21 00:08:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2645863005/#ps20001
(title: "CR fixes")

[atotic, 2017-01-21 00:09:01]

https://codereview.chromium.org/2645863005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc (right):

https://codereview.chromium.org/2645863005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:200:
ComputeAbsoluteHorizontal(space, style, width, static_position,
On 2017/01/21 at 00:03:30, cbiesinger wrote:
> Can you add a comment on why it's safe to call this function recursively?
Something like:
> // Because this function only changes "width" when it's not already
> // set, it is safe to recursively call ourselves here because on the
> // second call it is guaranteed to be within min..max.

done

[commit-bot: I haz the power, 2017-01-21 00:09:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 03:41:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484957332363620,
"parent_rev": "c3d95b718b20fad7919e64d28faf6d3a45d1a76d", "commit_rev":
"0e7df9ebd6385e1f02a328f864c8bff48eb5cbeb"}

[commit-bot: I haz the power, 2017-01-21 03:42:08]

Description was changed from

==========
Fix how we constrain width/height by min/max

According to the spec:
- if min/max change the computed length, the algorithm should run
again with length being the clamped length value.

This also fixes a single failing test.

BUG=635619
==========

to

==========
Fix how we constrain width/height by min/max

According to the spec:
- if min/max change the computed length, the algorithm should run
again with length being the clamped length value.

This also fixes a single failing test.

BUG=635619

Review-Url: https://codereview.chromium.org/2645863005
Cr-Commit-Position: refs/heads/master@{#445267}
Committed:
https://chromium.googlesource.com/chromium/src/+/0e7df9ebd6385e1f02a328f864c8...
==========

[commit-bot: I haz the power, 2017-01-21 03:42:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0e7df9ebd6385e1f02a328f864c8...