Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2644513005: Suppress deprecation warning for LOC_PROV_ALLOWED (Closed)

Created:
3 years, 11 months ago by cco3
Modified:
3 years, 11 months ago
Reviewers:
Maria
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress deprecation warning for LOC_PROV_ALLOWED Settings.Secure.LOCATION_PROVIDERS_ALLOWED is deprecated in API 19. This change suppresses that warning. Review-Url: https://codereview.chromium.org/2644513005 Cr-Commit-Position: refs/heads/master@{#445234} Committed: https://chromium.googlesource.com/chromium/src/+/5c560285cdbce6cebc187c20d60fcea9c836c4ec

Patch Set 1 #

Patch Set 2 : Suppress deprecation warning for LOC_PROV_ALLOWED #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
cco3
3 years, 11 months ago (2017-01-20 19:37:51 UTC) #2
Maria
On 2017/01/20 19:37:51, cco3 wrote: Will this constant be removed in O? Then we will ...
3 years, 11 months ago (2017-01-20 20:38:56 UTC) #3
cco3
It looks like it will still be around in 26. If we are still supporting ...
3 years, 11 months ago (2017-01-20 21:22:19 UTC) #4
Maria
lgtm
3 years, 11 months ago (2017-01-21 00:09:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644513005/20001
3 years, 11 months ago (2017-01-21 00:10:19 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 00:54:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5c560285cdbce6cebc187c20d60f...

Powered by Google App Engine
This is Rietveld 408576698