[pattern rewriter] Only desugar to call %ToName on computed properties

[pattern rewriter] Only desugar to call %ToName on computed properties

Convert strings to numbers if possible in the runtime call and store
in excluded property list.

BUG=v8:5549
Review-Url: https://codereview.chromium.org/2639333004
Cr-Commit-Position: refs/heads/master@{#42581}
Committed: https://chromium.googlesource.com/v8/v8/+/72e8a978155394b0c67b07404f5241594f42c906

[gsathya, 2017-01-19 00:43:48]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 00:43:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 00:45:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 00:45:39]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/15948)

[adamk, 2017-01-19 02:04:12]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2017-01-19 02:04:13]

https://codereview.chromium.org/2639333004/diff/1/src/parsing/pattern-rewrite...
File src/parsing/pattern-rewriter.cc (right):

https://codereview.chromium.org/2639333004/diff/1/src/parsing/pattern-rewrite...
src/parsing/pattern-rewriter.cc:364: // var y = temp[y];
Isn't this temp.y?

https://codereview.chromium.org/2639333004/diff/1/src/parsing/pattern-rewrite...
src/parsing/pattern-rewriter.cc:391: }
Can you add a DCHECK in the else branch about the type of this literal?
Something like

DCHECK(key->IsPropertyName() || key->raw_value()->IsNumber())

which means we couldn't end up with, say, a literal null or a literal true here?
Actually I'm not sure that we don't. Maybe add some tests with computed
properties that are literals?

{ [null]: x, ...y } // should exclude the key "null"

{ [true]: x, ...y } // should exclude "true"

{ [false]: x ] } // should exclude "false"

[seanmccullough1, 2017-01-19 19:04:08]

The CQ bit was checked by seanmccullough@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 19:04:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 19:29:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 19:29:44]

Dry run: This issue passed the CQ dry run.

[gsathya, 2017-01-20 23:49:49]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 23:50:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2017-01-20 23:51:10]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 23:51:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 00:06:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 00:06:46]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[gsathya, 2017-01-21 00:09:18]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 00:09:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2017-01-21 00:27:21]

Description was changed from

==========
[pattern rewriter] Only desugar to call %ToName on computed properties

Convert strings to numbers if possible in the runtime call and store
in excluded property list.

BUG=v8:5549
==========

to

==========
[pattern rewriter] Only desugar to call %ToName on computed properties

Convert strings to numbers if possible in the runtime call and store
in excluded property list.

BUG=v8:5549
==========

[gsathya, 2017-01-21 00:27:21]

gsathya@chromium.org changed reviewers:
- seanmccullough@google.com

[gsathya, 2017-01-21 00:27:33]

https://codereview.chromium.org/2639333004/diff/1/src/parsing/pattern-rewrite...
File src/parsing/pattern-rewriter.cc (right):

https://codereview.chromium.org/2639333004/diff/1/src/parsing/pattern-rewrite...
src/parsing/pattern-rewriter.cc:364: // var y = temp[y];
On 2017/01/19 02:04:13, adamk wrote:
> Isn't this temp.y?

Done.

https://codereview.chromium.org/2639333004/diff/1/src/parsing/pattern-rewrite...
src/parsing/pattern-rewriter.cc:391: }
On 2017/01/19 02:04:13, adamk wrote:
> Can you add a DCHECK in the else branch about the type of this literal?
> Something like
> 
> DCHECK(key->IsPropertyName() || key->raw_value()->IsNumber())
> 
> which means we couldn't end up with, say, a literal null or a literal true
here?
> Actually I'm not sure that we don't. Maybe add some tests with computed
> properties that are literals?
> 
> { [null]: x, ...y } // should exclude the key "null"
> 
> { [true]: x, ...y } // should exclude "true"
> 
> { [false]: x ] } // should exclude "false"

Done.

[gsathya, 2017-01-21 00:32:05]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 00:32:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2017-01-21 00:33:32]

lgtm

[commit-bot: I haz the power, 2017-01-21 01:07:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 01:07:23]

Dry run: This issue passed the CQ dry run.

[gsathya, 2017-01-21 01:07:41]

The CQ bit was checked by gsathya@chromium.org

[commit-bot: I haz the power, 2017-01-21 01:07:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 01:09:47]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484960861907780,
"parent_rev": "380b720d3cfa9d8377176033298158f6d0d3c78f", "commit_rev":
"72e8a978155394b0c67b07404f5241594f42c906"}

[commit-bot: I haz the power, 2017-01-21 01:09:52]

Description was changed from

==========
[pattern rewriter] Only desugar to call %ToName on computed properties

Convert strings to numbers if possible in the runtime call and store
in excluded property list.

BUG=v8:5549
==========

to

==========
[pattern rewriter] Only desugar to call %ToName on computed properties

Convert strings to numbers if possible in the runtime call and store
in excluded property list.

BUG=v8:5549

Review-Url: https://codereview.chromium.org/2639333004
Cr-Commit-Position: refs/heads/master@{#42581}
Committed:
https://chromium.googlesource.com/v8/v8/+/72e8a978155394b0c67b07404f5241594f4...
==========

[commit-bot: I haz the power, 2017-01-21 01:09:53]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/72e8a978155394b0c67b07404f5241594f4...