Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2620623002: Implement display:flow-root (Closed)

Created:
3 years, 11 months ago by rhogan
Modified:
3 years, 11 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement display:flow-root display:flow-root generates a block container box, and lays out its contents using flow layout. It always establishes a new block formatting context for its contents. Intent to implement issued at: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/k9WOAVA5Ewc Test=display-flow-root-001.html taken from the Mozilla test-suite https://www.chromestatus.com/features/5769454877147136 TBR=pfeldman@chromium.org BUG=672508 Review-Url: https://codereview.chromium.org/2620623002 Cr-Commit-Position: refs/heads/master@{#445258} Committed: https://chromium.googlesource.com/chromium/src/+/0010b369bbcf9235abd54ba181ef07b0cf6b7d6f

Patch Set 1 #

Patch Set 2 : bug 672508 #

Patch Set 3 : bug 672508 #

Total comments: 2

Patch Set 4 : bug 672508 #

Patch Set 5 : bug 672508 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/float/display-flow-root-001.html View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/float/display-flow-root-001-expected.html View 1 chunk +51 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/autocomplete-css-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueKeywords.json5 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 43 (31 generated)
rhogan
3 years, 11 months ago (2017-01-09 19:05:52 UTC) #15
eae
LGTM
3 years, 11 months ago (2017-01-09 19:42:51 UTC) #16
rhogan
On 2017/01/09 at 19:42:51, eae wrote: > LGTM Thanks eae. Do I need to collect ...
3 years, 11 months ago (2017-01-09 19:46:27 UTC) #17
Manuel Rego
A generic comment, now that we're implementing some new values for "display" property (like "flow-root" ...
3 years, 11 months ago (2017-01-09 20:34:05 UTC) #19
mstensho (USE GERRIT)
https://codereview.chromium.org/2620623002/diff/40001/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp File third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp (right): https://codereview.chromium.org/2620623002/diff/40001/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp#newcode86 third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp:86: case EDisplay::FlowRoot: Shouldn't you just return EDisplay::FlowRoot in this ...
3 years, 11 months ago (2017-01-09 20:37:58 UTC) #21
eae
On 2017/01/09 19:46:27, rhogan wrote: > On 2017/01/09 at 19:42:51, eae wrote: > > LGTM ...
3 years, 11 months ago (2017-01-10 21:57:41 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620623002/60001
3 years, 11 months ago (2017-01-20 23:17:41 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/139792) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-20 23:19:49 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620623002/80001
3 years, 11 months ago (2017-01-20 23:49:47 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/346902)
3 years, 11 months ago (2017-01-20 23:57:24 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620623002/80001
3 years, 11 months ago (2017-01-21 00:09:37 UTC) #40
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 02:59:52 UTC) #43
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0010b369bbcf9235abd54ba181ef...

Powered by Google App Engine
This is Rietveld 408576698