Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 261543003: Linux sandbox: allow *kill on ASAN (Closed)

Created:
6 years, 7 months ago by jln (very slow on Chromium)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Linux sandbox: allow *kill on ASAN Restricting *kill on ASAN is crashing somehow. Allow *kill on ASAN for now. BUG=367986 R=jorgelo@chromium.org, mdempsky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267005

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address nits. #

Patch Set 3 : Address nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -12 lines) Patch
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc View 1 2 chunks +30 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jln (very slow on Chromium)
Matthew / Jorge, could one of you take a look quickly so that I can ...
6 years, 7 months ago (2014-04-30 00:17:19 UTC) #1
mdempsky
lgtm
6 years, 7 months ago (2014-04-30 00:20:36 UTC) #2
mdempsky
https://chromiumcodereview.appspot.com/261543003/diff/1/sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc File sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc (right): https://chromiumcodereview.appspot.com/261543003/diff/1/sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc#newcode238 sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc:238: // strange This comment is wrapped oddly though.
6 years, 7 months ago (2014-04-30 00:21:14 UTC) #3
Jorge Lucangeli Obes
lgtm, if you can fix the comment wrapping, even better. https://chromiumcodereview.appspot.com/261543003/diff/1/sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc File sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc (right): https://chromiumcodereview.appspot.com/261543003/diff/1/sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc#newcode238 ...
6 years, 7 months ago (2014-04-30 00:22:05 UTC) #4
jln (very slow on Chromium)
Thanks! https://chromiumcodereview.appspot.com/261543003/diff/1/sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc File sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc (right): https://chromiumcodereview.appspot.com/261543003/diff/1/sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc#newcode238 sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc:238: // strange On 2014/04/30 00:21:14, mdempsky wrote: > ...
6 years, 7 months ago (2014-04-30 00:27:49 UTC) #5
jln (very slow on Chromium)
6 years, 7 months ago (2014-04-30 00:28:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r267005 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698