Issue 25853003: Make checkout.GitCheckout usable from apply_issue

Issue 25853003: Make checkout.GitCheckout usable from apply_issue (Closed)

Created:
7 years, 2 months ago by rmistry

Modified:
7 years, 2 months ago

Reviewers:
Marc-Antoine Ruel (Google), M-A Ruel, iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, skiabot_google.com

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

Make checkout.GitCheckout usable from apply_issue BUG=chromium:303433 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=226774

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
	M	apply_issue.py	View	1	1 chunk	+1 line, -1 line	1 comment	Download
	M	checkout.py	View	1	5 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Marc-Antoine Ruel (Google)

I'm at the limit where I'd ask for 'master' to be a member variable but ...

7 years, 2 months ago (2013-10-03 15:28:35 UTC) #2

rmistry

On 2013/10/03 15:28:35, Marc-Antoine Ruel (Google) wrote: > I'm at the limit where I'd ask ...

7 years, 2 months ago (2013-10-03 16:47:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmistry@google.com/25853003/4001

7 years, 2 months ago (2013-10-03 16:52:10 UTC) #5

iannucci

7 years, 2 months ago (2013-10-03 17:50:01 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/25853003/diff/4001/apply_issue.py
File apply_issue.py (right):

https://codereview.chromium.org/25853003/diff/4001/apply_issue.py#newcode147
apply_issue.py:147: scm_obj = checkout.GitCheckout(full_dir, None, None, None,
None)
blarg, we should really call these by kwarg. I have no idea what these None's
are for... brings back bad memories of Win32 api days :p

Expand Messages | Collapse Messages