Make checkout.GitCheckout usable from apply_issue

apply_issue.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Applies an issue from Rietveld.
 """
 
 import getpass
 import logging
@@ skipping 126 matching lines @@
             options.issue, options.patchset,
             options.server, options.issue)
     return 1
   for patch in patchset.patches:
     print(patch)
   full_dir = os.path.abspath(options.root_dir)
   scm_type = scm.determine_scm(full_dir)
   if scm_type == 'svn':
     scm_obj = checkout.SvnCheckout(full_dir, None, None, None, None)
   elif scm_type == 'git':
-    scm_obj = checkout.GitCheckout(full_dir, None, None)
+    scm_obj = checkout.GitCheckout(full_dir, None, None, None, None)

[iannucci, 2013/10/03 17:50:01]

blarg, we should really call these by kwarg. I have no idea what these None's
are for... brings back bad memories of Win32 api days :p

   elif scm_type == None:
     scm_obj = checkout.RawCheckout(full_dir, None, None)
   else:
     parser.error('Couldn\'t determine the scm')
 
   # TODO(maruel): HACK, remove me.
   # When run a build slave, make sure buildbot knows that the checkout was
   # modified.
   if options.root_dir == 'src' and getpass.getuser() == 'chrome-bot':
     # See sourcedirIsPatched() in:
@@ skipping 27 matching lines @@
             '--nohooks',
             '--delete_unversioned_trees',
           ],
           cwd=gclient_root)
   return 0
 
 
 if __name__ == "__main__":
   fix_encoding.fix_encoding()
   sys.exit(main())