Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 25722010: Add support for micro-tasks in Dartium. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add support for micro-tasks in Dartium. We are using the MutationObserver to schedule immediate events. BUG= R=blois@google.com, floitsch@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=28715

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reues both dummy-element and MutationObserver. #

Total comments: 2

Patch Set 3 : Rename stuff. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M tests/lib/lib.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 2 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Anders Johnsen
This patch is based on the work in https://codereview.chromium.org/25646004/. WebKit binding CL: https://codereview.chromium.org/25846004/
7 years, 2 months ago (2013-10-03 14:46:36 UTC) #1
blois
https://codereview.chromium.org/25722010/diff/1/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/25722010/diff/1/tools/dom/src/native_DOMImplementation.dart#newcode420 tools/dom/src/native_DOMImplementation.dart:420: _enqueueImmediateHelperNode.attributes.clear(); The attributes getter isn't as lightweight as it ...
7 years, 2 months ago (2013-10-03 16:54:29 UTC) #2
Anders Johnsen
PTAL https://codereview.chromium.org/25722010/diff/1/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/25722010/diff/1/tools/dom/src/native_DOMImplementation.dart#newcode420 tools/dom/src/native_DOMImplementation.dart:420: _enqueueImmediateHelperNode.attributes.clear(); On 2013/10/03 16:54:29, blois wrote: > The ...
7 years, 2 months ago (2013-10-10 14:48:54 UTC) #3
floitsch
LGTM. Please wait for an LGTM from HTML devs. https://codereview.chromium.org/25722010/diff/6001/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/25722010/diff/6001/tools/dom/src/native_DOMImplementation.dart#newcode531 tools/dom/src/native_DOMImplementation.dart:531: ...
7 years, 2 months ago (2013-10-10 16:02:17 UTC) #4
blois
lgtm
7 years, 2 months ago (2013-10-10 17:12:22 UTC) #5
vsm
lgtm
7 years, 2 months ago (2013-10-11 19:49:58 UTC) #6
Anders Johnsen
@floitch, PTAL after renaming. https://chromiumcodereview.appspot.com/25722010/diff/6001/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://chromiumcodereview.appspot.com/25722010/diff/6001/tools/dom/src/native_DOMImplementation.dart#newcode531 tools/dom/src/native_DOMImplementation.dart:531: final Element _dummy = new ...
7 years, 2 months ago (2013-10-15 17:21:17 UTC) #7
floitsch
LGTM.
7 years, 2 months ago (2013-10-15 17:24:35 UTC) #8
Anders Johnsen
7 years, 2 months ago (2013-10-16 09:16:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 manually as r28715 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698