Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 25675008: Updating CustomElement lifecycle scope logic (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Updating CustomElement lifecycle scope logic More closely following what V8 is doing in: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.pm&l=1725 Primary issue was that this was being emitted in too many places (getters and attributes which didn't need it). BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=28818

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M tools/dom/scripts/systemnative.py View 1 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 2 months ago (2013-10-03 16:18:22 UTC) #1
vsm
lgtm https://chromiumcodereview.appspot.com/25675008/diff/1/tools/dom/scripts/systemnative.py File tools/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/25675008/diff/1/tools/dom/scripts/systemnative.py#newcode795 tools/dom/scripts/systemnative.py:795: if generate_custom_element_scope_if_needed and (ext_attrs.get('CustomElementCallbacks', 'None') != 'None' or ...
7 years, 2 months ago (2013-10-03 16:20:41 UTC) #2
blois
7 years, 2 months ago (2013-10-17 20:13:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r28818 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698