Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: net/quic/core/crypto/crypto_server_test.cc

Issue 2566783002: Various formatting cleanups to net/quic/crypto and net/quic/congestion_control (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/crypto/crypto_server_config_protobuf.h ('k') | net/quic/core/crypto/crypto_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/crypto/crypto_server_test.cc
diff --git a/net/quic/core/crypto/crypto_server_test.cc b/net/quic/core/crypto/crypto_server_test.cc
index fdf91b7c6bbcb71d614122bda37aa703853d1f73..5d0e30c2e50075c0dc6fc974a44a2948459d1147 100644
--- a/net/quic/core/crypto/crypto_server_test.cc
+++ b/net/quic/core/crypto/crypto_server_test.cc
@@ -8,7 +8,6 @@
#include <ostream>
#include <vector>
-#include "base/strings/string_number_conversions.h"
#include "crypto/secure_hash.h"
#include "net/quic/core/crypto/cert_compressor.h"
#include "net/quic/core/crypto/common_cert_set.h"
@@ -45,7 +44,7 @@ class DummyProofVerifierCallback : public ProofVerifierCallback {
void Run(bool ok,
const std::string& error_details,
std::unique_ptr<ProofVerifyDetails>* details) override {
- // Do nothing
+ DCHECK(false);
}
};
@@ -862,6 +861,7 @@ TEST_P(CryptoServerTest, ProofForSuppliedServerConfig) {
"#004b5453", srct_hex_.c_str(),
"PUBS", pub_hex_.c_str(),
"NONC", nonce_hex_.c_str(),
+ "NONP", "123456789012345678901234567890",
"VER\0", client_version_string_.c_str(),
"XLCT", XlctHexString().c_str(),
"$padding", static_cast<int>(kClientHelloMinimumSize),
@@ -952,7 +952,6 @@ TEST_P(CryptoServerTest, ValidXlct) {
"#004b5453", srct_hex_.c_str(),
"PUBS", pub_hex_.c_str(),
"NONC", nonce_hex_.c_str(),
- "NONP", "123456789012345678901234567890",
"VER\0", client_version_string_.c_str(),
"XLCT", XlctHexString().c_str(),
"$padding", static_cast<int>(kClientHelloMinimumSize),
« no previous file with comments | « net/quic/core/crypto/crypto_server_config_protobuf.h ('k') | net/quic/core/crypto/crypto_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698