Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 25512005: Enable experimental support for sub-pixel font scaling (Closed)

Created:
7 years, 2 months ago by eae
Modified:
7 years ago
Reviewers:
dglazkov, eseidel
CC:
blink-reviews, Dirk Pranke
Visibility:
Public.

Description

Enable experimental support for sub-pixel font scaling Enable sub-css-pixel font scaling as an experimental web feature. This would allow for things like font-size: 12.5px which would map to 25 device pixels on a high dpi display or when zoomed in. It also allows for smoother text scaling and consistent sizing across zoom levels. R=dglazkov@chromium.org BUG=290411 TEST=fast/text/sub-pixel/text-scaling* Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162893

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+686 lines, -24 lines) Patch
M LayoutTests/TestExpectations View 1 6 chunks +353 lines, -5 lines 0 comments Download
M LayoutTests/css3/zoom-coords.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/box-decoration-break/box-decoration-break-rendering.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/box-decoration-break/box-decoration-break-rendering-expected.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css-generated-content/after-with-inline-continuation.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-generated-content/after-with-inline-continuation-expected.html View 1 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/fast/text-autosizing/clusters-insufficient-text.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text-autosizing/clusters-insufficient-text-expected.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text-autosizing/clusters-sufficient-text-except-in-root.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text-autosizing/clusters-sufficient-text-except-in-root-expected.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text-autosizing/clusters-sufficient-width.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/text-autosizing/clusters-sufficient-width-expected.html View 1 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/text/sub-pixel/resources/text-scaling.css View 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/sub-pixel/resources/text-scaling.js View 1 chunk +79 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/sub-pixel/text-scaling-ltr.html View 1 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/sub-pixel/text-scaling-ltr-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/sub-pixel/text-scaling-pixel.html View 1 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/sub-pixel/text-scaling-rtl.html View 1 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/sub-pixel/text-scaling-rtl-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/sub-pixel/text-scaling-vertical.html View 1 1 chunk +53 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/sub-pixel/text-scaling-vertical-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/platform/graphics/FontFastPath.cpp View 1 2 chunks +11 lines, -3 lines 0 comments Download
M Source/core/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp View 1 1 chunk +6 lines, -1 line 0 comments Download
M Source/core/platform/graphics/win/FontPlatformDataWin.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/rendering/LineWidth.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
dglazkov
lgtm, though this patch seems to include that other one.
7 years, 1 month ago (2013-11-18 22:56:59 UTC) #1
eae
On 2013/11/18 22:56:59, Dimitri Glazkov wrote: > lgtm, though this patch seems to include that ...
7 years, 1 month ago (2013-11-18 23:01:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/25512005/162001
7 years ago (2013-11-29 09:48:19 UTC) #3
commit-bot: I haz the power
Change committed as 162893
7 years ago (2013-11-29 11:12:53 UTC) #4
eseidel
I think this broke several SVG text-related tests? svg/batik/text/textProperties.svg svg/batik/text/textLayout2.svg see garden-o-matic.appspot.com
7 years ago (2013-11-30 02:54:46 UTC) #5
eae
7 years ago (2013-11-30 03:03:57 UTC) #6
On Sat, Nov 30, 2013 at 10:54 AM,  <eseidel@chromium.org> wrote:
> I think this broke several SVG text-related tests?
> svg/batik/text/textProperties.svg
> svg/batik/text/textLayout2.svg
> see garden-o-matic.appspot.com

Yeah, some of the rebaselines got messed up, seems like the lion and
snowleopard ones got swapped.

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698