Issue 25463003: Fix UTF8 encoder for Unicode runes > 0xFFFF.

Issue 25463003: Fix UTF8 encoder for Unicode runes > 0xFFFF. (Closed)

Created:
7 years, 2 months ago by floitsch

Modified:
7 years, 2 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix UTF8 encoder for Unicode runes > 0xFFFF. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=28095

Patch Set 2 : Remove private duplicated variables. #

Patch Set 3 : Reupload due to error. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -19 lines)			Patch
M	sdk/lib/convert/utf.dart	View	1	10 chunks	+17 lines, -11 lines	0 comments	Download
M	tests/lib/convert/unicode_tests.dart	View		2 chunks	+4 lines, -0 lines	0 comments	Download
A +	tests/lib/convert/utf85_test.dart	View		1 chunk	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM, thanks! https://codereview.chromium.org/25463003/diff/1/sdk/lib/convert/utf.dart File sdk/lib/convert/utf.dart (right): https://codereview.chromium.org/25463003/diff/1/sdk/lib/convert/utf.dart#newcode54 sdk/lib/convert/utf.dart:54: * If the [codeUnits] start with a ...

7 years, 2 months ago (2013-10-01 11:32:29 UTC) #2

floitsch

https://codereview.chromium.org/25463003/diff/1/sdk/lib/convert/utf.dart File sdk/lib/convert/utf.dart (right): https://codereview.chromium.org/25463003/diff/1/sdk/lib/convert/utf.dart#newcode54 sdk/lib/convert/utf.dart:54: * If the [codeUnits] start with a leading [UNICODE_BOM_CHARACTER_RUNE] ...

7 years, 2 months ago (2013-10-01 11:37:42 UTC) #3

floitsch

7 years, 2 months ago (2013-10-01 12:11:19 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r28095 (presubmit successful).

Expand Messages | Collapse Messages