Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1443)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 25366003: Moved some functions off ExtensionService into a new file extension_util. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile failures Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
index bd92c260a2feefd70125c70c4618cdf08a4fe1da..eb81a66e71fcf2a7526c4fa8e1c8f7e3041a3682 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
@@ -27,6 +27,7 @@
#include "chrome/browser/extensions/extension_error_reporter.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/management_policy.h"
#include "chrome/browser/extensions/unpacked_installer.h"
#include "chrome/browser/extensions/updater/extension_updater.h"
@@ -341,9 +342,10 @@ scoped_ptr<developer::ItemInfo>
}
}
- info->incognito_enabled = service->IsIncognitoEnabled(item.id());
+ info->incognito_enabled =
+ extension_util::IsIncognitoEnabled(item.id(),service);
info->wants_file_access = item.wants_file_access();
- info->allow_file_access = service->AllowFileAccess(&item);
+ info->allow_file_access = extension_util::AllowFileAccess(&item, service);
info->allow_reload = Manifest::IsUnpackedLocation(item.location());
info->is_unpacked = Manifest::IsUnpackedLocation(item.location());
info->terminated = service->terminated_extensions()->Contains(item.id());
@@ -608,7 +610,7 @@ bool DeveloperPrivateAllowFileAccessFunction::RunImpl() {
<< extension->id();
result = false;
} else {
- service->SetAllowFileAccess(extension, params->allow);
+ extension_util::SetAllowFileAccess(extension, service, params->allow);
result = true;
}
@@ -630,7 +632,8 @@ bool DeveloperPrivateAllowIncognitoFunction::RunImpl() {
if (!extension)
result = false;
else
- service->SetIsIncognitoEnabled(extension->id(), params->allow);
+ extension_util::SetIsIncognitoEnabled(
+ extension->id(),service, params->allow);
return result;
}

Powered by Google App Engine
This is Rietveld 408576698