Moved some functions off ExtensionService into a new file extension_util.

chrome/browser/extensions/api/developer_private/developer_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/developer_private/developer_private_api.h"
 
 #include "apps/app_load_service.h"
 #include "apps/app_restore_service.h"
 #include "apps/saved_files_service.h"
 #include "apps/shell_window.h"
 #include "apps/shell_window_registry.h"
 #include "base/base64.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/file_enumerator.h"
 #include "base/i18n/file_util_icu.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/devtools/devtools_window.h"
 #include "chrome/browser/extensions/api/developer_private/developer_private_api_factory.h"
 #include "chrome/browser/extensions/api/developer_private/entry_picker.h"
 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
 #include "chrome/browser/extensions/devtools_util.h"
 #include "chrome/browser/extensions/extension_disabled_ui.h"
 #include "chrome/browser/extensions/extension_error_reporter.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/management_policy.h"
 #include "chrome/browser/extensions/unpacked_installer.h"
 #include "chrome/browser/extensions/updater/extension_updater.h"
 #include "chrome/browser/platform_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.h"
 #include "chrome/browser/sync_file_system/syncable_file_system_util.h"
 #include "chrome/browser/ui/chrome_select_file_policy.h"
 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
 #include "chrome/common/extensions/api/developer_private.h"
@@ skipping 294 matching lines @@
         new std::string(UTF16ToUTF8(item.path().LossyDisplayName())));
     for (std::vector<extensions::InstallWarning>::const_iterator it =
              item.install_warnings().begin();
          it != item.install_warnings().end(); ++it) {
       developer::InstallWarning* warning = new developer::InstallWarning();
       warning->message = it->message;
       info->install_warnings.push_back(make_linked_ptr(warning));
     }
   }
 
-  info->incognito_enabled = service->IsIncognitoEnabled(item.id());
+  info->incognito_enabled =
+      extension_util::IsIncognitoEnabled(item.id(),service);
   info->wants_file_access = item.wants_file_access();
-  info->allow_file_access = service->AllowFileAccess(&item);
+  info->allow_file_access = extension_util::AllowFileAccess(&item, service);
   info->allow_reload = Manifest::IsUnpackedLocation(item.location());
   info->is_unpacked = Manifest::IsUnpackedLocation(item.location());
   info->terminated = service->terminated_extensions()->Contains(item.id());
   info->allow_incognito = item.can_be_incognito_enabled();
 
   info->homepage_url.reset(new std::string(
       ManifestURL::GetHomepageURL(&item).spec()));
   if (!ManifestURL::GetOptionsPage(&item).is_empty()) {
     info->options_url.reset(
         new std::string(ManifestURL::GetOptionsPage(&item).spec()));
@@ skipping 244 matching lines @@
   bool result = true;
 
   if (!extension) {
     result = false;
   } else if (!management_policy->UserMayModifySettings(extension, NULL)) {
     LOG(ERROR) << "Attempt to change allow file access of an extension that "
                << "non-usermanagable was made. Extension id : "
                << extension->id();
     result = false;
   } else {
-    service->SetAllowFileAccess(extension, params->allow);
+    extension_util::SetAllowFileAccess(extension, service, params->allow);
     result = true;
   }
 
   return result;
 }
 
 DeveloperPrivateAllowFileAccessFunction::
     ~DeveloperPrivateAllowFileAccessFunction() {}
 
 bool DeveloperPrivateAllowIncognitoFunction::RunImpl() {
   scoped_ptr<AllowIncognito::Params> params(
       AllowIncognito::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   ExtensionService* service = profile()->GetExtensionService();
   const Extension* extension = service->GetInstalledExtension(params->item_id);
   bool result = true;
 
   if (!extension)
     result = false;
   else
-    service->SetIsIncognitoEnabled(extension->id(), params->allow);
+    extension_util::SetIsIncognitoEnabled(
+        extension->id(),service, params->allow);
 
   return result;
 }
 
 DeveloperPrivateAllowIncognitoFunction::
     ~DeveloperPrivateAllowIncognitoFunction() {}
 
 
 bool DeveloperPrivateReloadFunction::RunImpl() {
   scoped_ptr<Reload::Params> params(Reload::Params::Create(*args_));
@@ skipping 697 matching lines @@
   return true;
 }
 
 DeveloperPrivateIsProfileManagedFunction::
     ~DeveloperPrivateIsProfileManagedFunction() {
 }
 
 } // namespace api
 
 } // namespace extensions