Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 25132005: Web Animations CSS: Handle border-spacing property (Closed)

Created:
7 years, 2 months ago by Steve Block
Modified:
7 years, 2 months ago
Reviewers:
dstockwell
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Web Animations CSS: Handle border-spacing property BUG=240653 R=dstockwell Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158520

Patch Set 1 #

Patch Set 2 : Test via border-spacing property #

Patch Set 3 : Fix bad upload #

Total comments: 2

Patch Set 4 : Remove text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -0 lines) Patch
A LayoutTests/animations/interpolation/border-spacing-interpolation.html View 1 2 3 1 chunk +72 lines, -0 lines 0 comments Download
A LayoutTests/animations/interpolation/border-spacing-interpolation-expected.txt View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
A LayoutTests/virtual/web-animations-css/animations/interpolation/border-spacing-interpolation-expected.txt View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Steve Block
7 years, 2 months ago (2013-09-30 06:13:42 UTC) #1
dstockwell
https://codereview.chromium.org/25132005/diff/9001/LayoutTests/animations/interpolation/border-spacing-interpolation.html File LayoutTests/animations/interpolation/border-spacing-interpolation.html (right): https://codereview.chromium.org/25132005/diff/9001/LayoutTests/animations/interpolation/border-spacing-interpolation.html#newcode25 LayoutTests/animations/interpolation/border-spacing-interpolation.html:25: <td>foo</td> Do we need this text? It's a bit ...
7 years, 2 months ago (2013-09-30 06:39:17 UTC) #2
Steve Block
https://codereview.chromium.org/25132005/diff/9001/LayoutTests/animations/interpolation/border-spacing-interpolation.html File LayoutTests/animations/interpolation/border-spacing-interpolation.html (right): https://codereview.chromium.org/25132005/diff/9001/LayoutTests/animations/interpolation/border-spacing-interpolation.html#newcode25 LayoutTests/animations/interpolation/border-spacing-interpolation.html:25: <td>foo</td> Done. There's still some whitespace in the output, ...
7 years, 2 months ago (2013-09-30 06:51:22 UTC) #3
dstockwell
lgtm
7 years, 2 months ago (2013-09-30 06:52:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/25132005/15001
7 years, 2 months ago (2013-09-30 06:52:54 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-09-30 08:03:02 UTC) #6
Message was sent while issue was closed.
Change committed as 158520

Powered by Google App Engine
This is Rietveld 408576698